Page MenuHomePhabricator

Use non-output handlebar template comments over output ones
Closed, ResolvedPublic

Description

Throughout handlebar templates there are HTML comments that are sent to the client without necessity.
We should rather use

{{! This comment will not be in the output }}

Event Timeline

Change 603608 had a related patch set uploaded (by Iniquity; owner: Iniquity):
[wikimedia/portals@master] Use non-output handlebar template comments over output ones

https://gerrit.wikimedia.org/r/603608

Change 665006 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[wikimedia/portals@master] Change Brackets at handlebars

https://gerrit.wikimedia.org/r/665006

Change 603608 abandoned by VolkerE:
[wikimedia/portals@master] Use non-output handlebar template comments over output ones

Reason:
for I216654ffd69166535da0d5bd55c723a3825d49c8

https://gerrit.wikimedia.org/r/603608

Change 665006 merged by jenkins-bot:
[wikimedia/portals@master] Use non-output handlebar template comments over output ones

https://gerrit.wikimedia.org/r/665006