Page MenuHomePhabricator

Language label disconnected from language select and should feature long-form of language title
Closed, ResolvedPublic


Language label is disconnected from language select due to wrong id/for reference and should feature long-form of language title.

Current markup:

<div class="hide-arrow">
<label for="language" id="jsLangLabel" class="js-langpicker-label">de</label><select id="searchLanguage" name="language">
<!-- 100,000+ content pages, sorted by romanization -->
<option value="ar" lang="ar">العربية</option><!-- Al-ʿArabīyah --></select>
<div class="styled-select-active-helper"></div>

Event Timeline

Volker_E created this task.Nov 8 2018, 2:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2018, 2:28 AM

Change 472373 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wikimedia/portals@master] Fix id for correct label association

Change 472373 merged by jenkins-bot:
[wikimedia/portals@master] Fix id for correct label association

Volker_E closed this task as Resolved.Nov 29 2018, 5:50 PM
Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
Volker_E removed a project: Patch-For-Review.