| Esanders | |
| Nov 8 2018, 5:23 PM |
| F28401202: image.png | |
| Mar 16 2019, 11:12 PM |
| F28401172: image.png | |
| Mar 16 2019, 11:12 PM |
| F28401083: image.png | |
| Mar 16 2019, 11:04 PM |
As shown in T206228, we usually spend more time generating page edit metadata than loading the actual page HTML. Page metadata includes
Firstly we should investigate whether this is a regression, or something we've just not noticed before.
Secondly, none of this data should block the loading of the editor, so we should be able to make the time to interactive lower in VE.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Release | None | T84936 Release VisualEditor-MediaWiki as "1.0" | ||
| Open | None | T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki | |||
| Open | None | T209955 [EPIC: Focus] Isolate Section Editing | |||
| Open | None | T209987 [Engineering EPIC]: Isolate Section Editing | |||
| Resolved | dchan | T76541 Client-side approach to true section editing: Load/display document-level data (e.g. internal lists, meta lists) for the whole document but only the content for a part of the document | |||
| Resolved | Esanders | T206228 Analyse load time performance of FA-length pages on mobile | |||
| Open | None | T209078 Edit page metadata is very slow to load from the Action API, slowing down VisualEditor initialization |
Change 473198 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Separate document HTML promise from edit metadata promise
It looks like a lot of this slowdown comes from building the red-link cache, which we should've dropped 18 months ago when it was upstreamed to Parsoid (T64803).
Change 492358 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Remove red-link cache warming
Change 492366 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Separate out templatesUsed from metadata
The two later patches may make the metadata requests fast enough that the first patch is less urgent. Let's see how it affects the real-world numbers.
Change 492358 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Remove red-link cache warming
Change 492366 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Separate out templatesUsed from metadata
Next steps: Ed to find out if these two patches make it fast enough so that the first patch becomes unnecessary.
Re-running the featured-article tests from T206228, metadata and page html now take about roughly the same time. The issue is now less severe, but there are probably more benefits to be had by not blocking on metadata at all.
Here is a 7-day rolling overage of 5th centile load times:
Given that the metadata request is still block in some cases (especially on shorter articles, or when loading the page a second time) we should go ahead and try and merge the metadata promise separation patch.
Change 473198 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Separate document HTML promise from edit metadata promise