Page MenuHomePhabricator
Create Task
Maniphest T209095

Disallow use of @access using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation
Closed, ResolvedPublic
Actions

Description

In my opinion the @access annotation can be replaced by @private or @protected as needed.

In the most cases it could just moved to the code and should be disallow in the mediawiki codestyle

Details

SubjectRepoBranchLines +/-
Disallow use of @accessmediawiki/tools/codesniffermaster+95 -2
Customize query in gerrit

Event Timeline

Umherirrender created this task.Nov 8 2018, 7:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2018, 7:54 PM
gerritbot subscribed.Dec 31 2018, 6:34 PM

Change 481651 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Disallow use of @access

https://gerrit.wikimedia.org/r/481651

gerritbot added a project: Patch-For-Review.Dec 31 2018, 6:34 PM
Umherirrender claimed this task.Dec 31 2018, 6:34 PM
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Jan 2 2019, 10:32 PM

Change 481651 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Disallow use of @access

https://gerrit.wikimedia.org/r/481651

Umherirrender closed this task as Resolved.Jan 2 2019, 10:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL