Maniphest T209113

Argument 1 passed to CentralAuthUser::getMasterInstance() must be an instance of User, null given,
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Paladox
	Nov 8 2018, 9:14 PM

Description

Hi, im getting this when migrating to actor:

[no req]   TypeError from line 144 of /srv/mediawiki/w/extensions/CentralAuth/includes/CentralAuthUser.php: Argument 1 passed to CentralAuthUser::getMasterInstance() must be an instance of User, null given, called in /srv/mediawiki/w/extensions/Flow/includes/TalkpageManager.php on line 254
Backtrace:
#0 /srv/mediawiki/w/extensions/Flow/includes/TalkpageManager.php(254): CentralAuthUser::getMasterInstance(NULL)
#1 /srv/mediawiki/w/extensions/Flow/includes/Conversion/Utils.php(470): Flow\TalkpageManager->getTalkpageManager()
#2 /srv/mediawiki/w/extensions/Flow/includes/Conversion/Utils.php(320): Flow\Conversion\Utils::generateForwardedCookieForCli()
#3 /srv/mediawiki/w/extensions/Flow/includes/Conversion/Utils.php(258): Flow\Conversion\Utils::makeVRSObject()
#4 /srv/mediawiki/w/extensions/Flow/includes/Conversion/Utils.php(228): Flow\Conversion\Utils::getVRSObject()
#5 /srv/mediawiki/w/extensions/Flow/Hooks.php(167): Flow\Conversion\Utils::isParsoidConfigured()
#6 /srv/mediawiki/w/includes/Setup.php(940): FlowHooks::initFlowExtension()
#7 /srv/mediawiki/w/maintenance/doMaintenance.php(81): require_once(string)
#8 /srv/mediawiki/w/maintenance/migrateActors.php(550): require_once(string)
#9 {main}

Im running mediawiki 1.31 and using php 7.2.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Flow	REL1_32	+4 -0	Add a null check in getTalkpageManager
mediawiki/extensions/Flow	REL1_31	+4 -0	Add a null check in getTalkpageManager
mediawiki/extensions/Flow	master	+0 -4	Revert "Add a null check in getTalkpageManager"
mediawiki/extensions/Flow	master	+4 -0	Add a null check in getTalkpageManager

Customize query in gerrit

Event Timeline

Paladox created this task.Nov 8 2018, 9:14 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 8 2018, 9:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 472516 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/Flow@master] Add a null check in getTalkpageManager

https://gerrit.wikimedia.org/r/472516

gerritbot added a project: Patch-For-Review.Nov 8 2018, 9:15 PM

Catrope closed this task as Resolved.Nov 13 2018, 8:41 AM

Catrope claimed this task.

Catrope reassigned this task from Catrope to Paladox.

Catrope added a subscriber: Catrope.

Change 472516 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add a null check in getTalkpageManager

https://gerrit.wikimedia.org/r/472516

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 13 2018, 9:00 AM

Change 473179 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/Flow@REL1_32] Add a null check in getTalkpageManager

https://gerrit.wikimedia.org/r/473179

Change 473180 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/Flow@REL1_31] Add a null check in getTalkpageManager

https://gerrit.wikimedia.org/r/473180

Change 473239 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Revert "Add a null check in getTalkpageManager"

https://gerrit.wikimedia.org/r/473239

Change 473239 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Revert "Add a null check in getTalkpageManager"

https://gerrit.wikimedia.org/r/473239

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 13 2018, 6:00 PM