Page MenuHomePhabricator
Create Task
Maniphest T209163

Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state
Closed, ResolvedPublic
Actions

Description

  1. Be logged out of VE, or otherwise in single-tab mode
  2. Visit https://en.wikipedia.org/wiki/User:Whatamidoing_(WMF)/sandbox?veaction=edit
  3. Note the URL changing to https://en.wikipedia.org/wiki/User:Whatamidoing_(WMF)/sandbox?veaction=edit&action=edit
  4. Reload the page
  5. Find you're now on the non-VE version instead

The likely vector of this happening would be someone else sharing a link, since if you're in single-tab mode the links we generate will be in the action=edit form already.

Details

SubjectRepoBranchLines +/-
ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab modemediawiki/extensions/VisualEditormaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DLynch created this task.Nov 9 2018, 5:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2018, 5:25 PM
DLynch renamed this task from Loading an edit page while logged out changes to URL to an incorrect state to Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state.Nov 9 2018, 5:31 PM
DLynch updated the task description. (Show Details)
Seb35 subscribed.Nov 10 2018, 10:07 AM

This wrong behaviour is present in the three modes (other than the mode "two buttons") when wgVisualEditorUseSingleEditTab is true.

It should be modified around here, probably by adding a stronger condition than if( mw.libs.ve.isSingleEditTab ).

JTannerWMF triaged this task as Medium priority.Nov 20 2018, 4:11 PM
JTannerWMF moved this task from To Triage to Bug Fixes on the VisualEditor board.
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 26 2018, 4:56 PM
matmarex mentioned this in T190765: 2017 wikitext editor doesn't load for some URL parameters, uses one of old editors instead (when VisualEditor is temporarily disabled).Apr 11 2019, 10:24 PM
matmarex added a parent task: T190765: 2017 wikitext editor doesn't load for some URL parameters, uses one of old editors instead (when VisualEditor is temporarily disabled).
gerritbot added a comment.Jul 30 2019, 11:11 PM

Change 526557 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab mode

https://gerrit.wikimedia.org/r/526557

gerritbot added a project: Patch-For-Review.Jul 30 2019, 11:11 PM
matmarex claimed this task.Jul 30 2019, 11:12 PM
matmarex added a project: VisualEditor-MediaWiki.
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Jul 31 2019, 1:29 PM

Change 526557 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Fix generated URL when loaded using veaction=edit in single-tab mode

https://gerrit.wikimedia.org/r/526557

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 2:12 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 31 2019, 4:54 PM
matmarex added a project: Editing QA.Aug 9 2019, 4:48 PM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Aug 9 2019, 4:57 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Sep 6 2019, 11:25 PM
matmarex moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 9 2019, 7:26 PM
• ppelberg closed this task as Resolved.Sep 20 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL