Page MenuHomePhabricator

Highlight to edit
Closed, ResolvedPublic

Description

User story

As an editor on the iOS app I would like to be able to quickly move from finding something on the article view to editing it in the editing view

Mocks

HighlightEdit screen loadedCursor placed and changed text
37 Highlight to edit.png (1×750 px, 343 KB)
38 Highlight to edit.png (1×750 px, 203 KB)
39 Highlight to edit.png (1×750 px, 185 KB)
Zeplin: https://zpl.io/VOmJL5LZeplin: https://zpl.io/2ZkpwK4Zeplin: https://zpl.io/29PBG0z

Design details

  • Edit is added to the highlight menu on the article view (NOTE: this mock is missing share options but those should not be removed)
  • Any text that is highlighted when the user taps 'edit' is highlighted in the edit view.
  • Added text in the are or deleted text is not highlighted
  • Highlight remains until the user leaves the editing view

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JMinor added subscribers: JoeWalsh, Dbrant, JMinor.

Although this is high priority for our overall plans, I'm marking this as a nice-to-have for now. I'd like to get a sense from @JoeWalsh how this could be done, and look at @Dbrant 's implementation on Android.

Additionally, there was discussion that "node level" APIs for parsing from html to wikitext and back (aka Parsoid) were a desirable future direction. It would be good to understand the potential needs for sub-section and more targeted editing as part of looking into this.

Pop the keyboard and put the cursor at the end for initial load

Second note to self: Change the highlight color, maybe an outline instead to differentiate it from selection