Maniphest T209185

Add test coverage for rlModuleLoader.js
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Currently rlModuleLoader.js is our only non-View code which has no test coverage and this makes me a sad panda. This task aims to make this 100%.

The rlModuleLoader wraps mw.loader.using and shows a spinner overlay until the module has finished loading

Developer notes

Add test coverage for rlModuleLoader.js

Risks:
1 function with various different code paths with async behaviour (with reject/done resolution behaviour), 1 optional parameter, use of new keyword

Sign off steps

Record progress

Coverage should be 100%. If not, please make a note on the table.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+8 -5	Add assertions for resolved value of promises in rlModuleLoader.test.js
	mediawiki/extensions/MobileFrontend	master	+181 -6	Add test coverage for rlModuleLoader.js

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	Jdlrobson	T209185 Add test coverage for rlModuleLoader.js

Event Timeline

Jdlrobson created this task.Nov 9 2018, 9:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2018, 9:17 PM

Jdlrobson triaged this task as High priority.Nov 9 2018, 9:17 PM

Jdlrobson added a parent task: T195478: [EPIC] Speed up unit test execution and increase code coverage.

Jdlrobson updated the task description. (Show Details)Nov 13 2018, 5:27 PM

Jdlrobson updated the task description. (Show Details)Nov 13 2018, 5:31 PM

Jdlrobson set the point value for this task to 3.

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Readers-Web-Backlog board.

Jdlrobson edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.

phuedx updated the task description. (Show Details)Nov 13 2018, 5:36 PM

nray claimed this task.Nov 15 2018, 4:31 PM

nray moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Change 473943 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Add test coverage for rlModuleLoader.js

https://gerrit.wikimedia.org/r/473943

gerritbot added a project: Patch-For-Review.Nov 15 2018, 10:49 PM

nray moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 15 2018, 10:55 PM

There was a conversation on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/473943/ about changing the loadModule function. Let's see if we can do this as part of this task. If it proves more complicated and merits a new task, please flag!

the proposal is to make loadModule take a second parameter - a LoadingOverlay.

Change 473943 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Add test coverage for rlModuleLoader.js

https://gerrit.wikimedia.org/r/473943

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 16 2018, 10:00 PM

Change 474397 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Add assertions for resolved value of promises in rlModuleLoader.test.js

https://gerrit.wikimedia.org/r/474397

Change 474398 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Change/Deprecate rlModuleLoader params

https://gerrit.wikimedia.org/r/474398

nray moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 17 2018, 1:31 AM

Change 474397 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add assertions for resolved value of promises in rlModuleLoader.test.js

https://gerrit.wikimedia.org/r/474397

Jdlrobson removed nray as the assignee of this task.Nov 20 2018, 6:10 PM

Jdlrobson added a subscriber: nray.

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 20 2018, 10:49 PM

DONE: 100% coverage! https://www.mediawiki.org/w/index.php?title=Reading%2FWeb%2FProjects%2FInvest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture%2FProgress&type=revision&diff=2975048&oldid=2968503
TODO: Review the stubbing mechanism we made use of here T210020 - it seems like we're not 100% happy with it.

Add test coverage for rlModuleLoader.jsClosed, ResolvedPublic3 Estimated Story PointsActions