Page MenuHomePhabricator

Convert Extension:UserAgreement to use OOUI
Closed, ResolvedPublic

Description

  • Used Button instead of CheckBox
Before:
and After:

Event Timeline

Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptNov 9 2018, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 472736 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/UserAgreement@master] Convert Extension:UserAgreement to use OOUI

https://gerrit.wikimedia.org/r/472736

I think we should Button Instead of CheckBox

User-story:- When I enable the Extension, My first approach was found the submit button as many sites and forums provide checkbox and button both. Then I thought that there is some problem in the code. So I have gone the source of extension, then I found there is no code for the button. After that, I realize that CheckBox is working to submit the action.

ping @Volker_E, For UX advise.

@Jayprakash12345 Yes, should definitely be a primary button instead!

@Jayprakash12345 Yes, should definitely be a primary button instead!

I support this!

Change 472736 merged by jenkins-bot:
[mediawiki/extensions/UserAgreement@master] Convert Extension:UserAgreement to use OOUI

https://gerrit.wikimedia.org/r/472736

Jayprakash12345 closed this task as Resolved.Nov 10 2018, 5:30 PM
Jayprakash12345 triaged this task as Normal priority.
Jayprakash12345 removed a project: Patch-For-Review.
Jayprakash12345 removed a subscriber: gerritbot.