Page MenuHomePhabricator

Drop down for menu options appears to be jittering for Firefox
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Open VE and make an edit.
  2. Save the page.
  3. Re-open the page with VE.
  4. Open any drop down such as Insert/Paragraph styling etc.
  5. Quickly scroll up and down

    Drop down for menu options appears to be jittering

Event Timeline

Ryasmeen created this task.Nov 9 2018, 10:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2018, 10:45 PM

The default position for the popups is inside toolbar.$element, which doesn't get position: fixed when floating. We can move the popup container to toolbar.$bar, which appears to resolve the issue, however in some cases the toolbar will have to be positioned outside of the toolbar, for example in ContentTranlsation where there are two toolbars. In these cases the issue will persist.

Change 473191 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Place popups instead toolbar.$bar

https://gerrit.wikimedia.org/r/473191

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 473191 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Place popups instead toolbar.$bar

https://gerrit.wikimedia.org/r/473191

Change 473569 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b17770c7e)

https://gerrit.wikimedia.org/r/473569

Change 473569 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b17770c7e)

https://gerrit.wikimedia.org/r/473569

Fixed, thanks!

marcella closed this task as Resolved.Nov 19 2018, 7:24 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 19 2018, 7:24 PM