Page MenuHomePhabricator
Create Task
Maniphest T209192

Drop down for menu options appears to be jittering for Firefox
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open VE and make an edit.
  2. Save the page.
  3. Re-open the page with VE.
  4. Open any drop down such as Insert/Paragraph styling etc.
  5. Quickly scroll up and down

    Drop down for menu options appears to be jittering

firefox.mov2 MBDownload

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (b17770c7e)mediawiki/extensions/VisualEditormaster+1 -1
Place popups instead toolbar.$barVisualEditor/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 9 2018, 10:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2018, 10:45 PM
Esanders added a comment.Nov 13 2018, 12:35 PM

The default position for the popups is inside toolbar.$element, which doesn't get position: fixed when floating. We can move the popup container to toolbar.$bar, which appears to resolve the issue, however in some cases the toolbar will have to be positioned outside of the toolbar, for example in ContentTranlsation where there are two toolbars. In these cases the issue will persist.

gerritbot subscribed.Nov 13 2018, 12:45 PM

Change 473191 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Place popups instead toolbar.$bar

https://gerrit.wikimedia.org/r/473191

gerritbot added a project: Patch-For-Review.Nov 13 2018, 12:45 PM
Esanders claimed this task.Nov 13 2018, 12:47 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 13 2018, 8:15 PM

Change 473191 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Place popups instead toolbar.$bar

https://gerrit.wikimedia.org/r/473191

gerritbot added a comment.Nov 14 2018, 5:42 PM

Change 473569 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b17770c7e)

https://gerrit.wikimedia.org/r/473569

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 14 2018, 6:52 PM
matmarex edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.
gerritbot added a comment.Nov 14 2018, 7:12 PM

Change 473569 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b17770c7e)

https://gerrit.wikimedia.org/r/473569

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 8:01 PM
Ryasmeen added a comment.Nov 14 2018, 10:08 PM

Fixed, thanks!

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Nov 14 2018, 10:09 PM
• marcella closed this task as Resolved.Nov 19 2018, 7:24 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 19 2018, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits