Page MenuHomePhabricator
Create Task
Maniphest T209194

Export one "real" ES6 class per file
Closed, ResolvedPublic
Actions

Description

This not only makes for smoother porting of PHP code but also improves code readability.

Details

SubjectRepoBranchLines +/-
Rename LinkHandler.js to WikiLinkHandler.jsmediawiki/services/parsoidmaster+2 -3
Split ExternalLinkHandler into its own classmediawiki/services/parsoidmaster+244 -229
Split Token types into separate classes in lib/tokensmediawiki/services/parsoidmaster+724 -740
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Nov 9 2018, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2018, 10:52 PM
ssastry triaged this task as Medium priority.Nov 9 2018, 10:52 PM
gerritbot subscribed.Nov 9 2018, 10:53 PM

Change 472747 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Split Token types into separate classes in lib/types

https://gerrit.wikimedia.org/r/472747

gerritbot added a project: Patch-For-Review.Nov 9 2018, 10:53 PM
gerritbot added a comment.Nov 13 2018, 9:50 PM

Change 472747 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Split Token types into separate classes in lib/tokens

https://gerrit.wikimedia.org/r/472747

ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.Nov 20 2018, 2:51 PM
gerritbot added a comment.Dec 20 2018, 5:14 PM

Change 480999 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Split ExternalLinkHandler into its own class

https://gerrit.wikimedia.org/r/480999

gerritbot added a comment.Dec 20 2018, 5:14 PM

Change 481000 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Rename LinkHandler.js to WikiLinkHandler.js

https://gerrit.wikimedia.org/r/481000

gerritbot added a comment.Dec 20 2018, 5:33 PM

Change 480999 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Split ExternalLinkHandler into its own class

https://gerrit.wikimedia.org/r/480999

gerritbot added a comment.Dec 20 2018, 5:33 PM

Change 481000 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Rename LinkHandler.js to WikiLinkHandler.js

https://gerrit.wikimedia.org/r/481000

Stashbot mentioned this in T197616: Create a production test wiki in group0 to parallel Wikimedia Commons.Jan 8 2019, 7:11 PM
Stashbot mentioned this in T205491: QuoteTransformer and quote-tokens use a ".value" property on the token instead of adding it to the token's attributes.
Stashbot mentioned this in T209772: visitDOM makes an invalid assumption about its handlers.
Stashbot mentioned this in T199926: html -> wt: Parsoid sometimes trips up on | chars in hrefs.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2019-01-08T19:11:39Z] <arlolra> Updated Parsoid to 2c5dc7b (T197616, T205491, T209772, T199926, T209194, T204622)

Stashbot mentioned this in T204622: Use native Javascript (ES6) classes instead of prototype-based definition pattern in the Parsoid codebase.Jan 8 2019, 7:11 PM
ssastry closed this task as Resolved.Feb 5 2019, 10:46 PM
ssastry removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL