Page MenuHomePhabricator

Bad behavior when pressing F11 on query.wikidata.org
Open, MediumPublic

Description

As an ... I want to ... in order to ...

Problem: When I have the focus on query.wikidata.org's code frame (CodeMirror) and I press F11 only the code frame is in full screen and the other HTML elements overlap it.

Example:

Screenshots/mockups:

BDD
GIVEN I am at https://query.wikidata.org
AND I have the focus on the code frame
WHEN I press F11 key
THEN all of the HTML elements continue being properly displayed in full screen

Acceptance criteria:

  • Pressing F11 on the query service correctly full screens the site.

Open questions:

Event Timeline

abian created this task.Nov 10 2018, 1:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2018, 1:24 PM
Addshore triaged this task as Medium priority.Nov 11 2018, 10:02 PM
Addshore moved this task from incoming to needs discussion or investigation on the Wikidata board.
Addshore added a subscriber: Addshore.

Confirmed on Windows 10 & Chrome 70

Addshore updated the task description. (Show Details)Nov 11 2018, 10:03 PM
Addshore moved this task from needs discussion or investigation to ready to go on the Wikidata board.
Addshore updated the task description. (Show Details)

Well, putting only the CodeMirror editor in fullscreen is intended as a feature (Ia45223f845), not a bug (note that it only happens when the editor is focused, otherwise F11 fullscreens the whole page, at least on my system). But it’s certainly not right that the query helper overlaps the editor – we should fix that part.

Hm, wait – when I try it out, only the query helper overlaps the editor, but in your screenshot there seem to be some more elements?

abian added a comment.EditedNov 12 2018, 12:39 PM

I can reproduce my screenshot by enabling the full screen on my browser (Firefox) and then pressing F11 while having the editor focused. Otherwise, I see everything approximately as you show.