Maniphest T209234

Use of User::setPassword was deprecated in MediaWiki 1.27.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Kizule
	Nov 11 2018, 1:52 PM

Description

https://integration.wikimedia.org/ci/job/quibble-composer-mysql-hhvm-docker/3018/console and previous tests related to my patch https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OAuthAuthentication/+/472865/ shows this:

14:43:15 1) MediaWiki\Extensions\OAuthAuthentication\OAuthAuthConfigTest::testGetDefaultConfig
14:43:15 Use of User::setPassword was deprecated in MediaWiki 1.27. [Called from MediaWiki\Extensions\OAuthAuthentication\OAuthAuthDBTest::setUp in /workspace/src/extensions/OAuthAuthentication/tests/phpunit/OAuthAuthDBTest.php at line 23]
14:43:15 
14:43:15 /workspace/src/includes/debug/MWDebug.php:309
14:43:15 /workspace/src/includes/debug/MWDebug.php:242
14:43:15 /workspace/src/includes/GlobalFunctions.php:1119
14:43:15 /workspace/src/includes/user/User.php:2896
14:43:15 /workspace/src/extensions/OAuthAuthentication/tests/phpunit/OAuthAuthDBTest.php:23
14:43:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
14:43:15 /workspace/src/maintenance/doMaintenance.php:94
14:43:15

Details

	Subject	Repo	Branch	Lines +/-
	Fix test setup using the getTestUser() infrastructure	mediawiki/extensions/OAuthAuthentication	master	+10 -10

Customize query in gerrit

Event Timeline

Kizule created this task.Nov 11 2018, 1:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2018, 1:52 PM

Aklapper added a project: Technical-Debt.Nov 11 2018, 2:24 PM

Izno moved this task from Unsorted to Deprecation process on the Technical-Debt board.Nov 11 2018, 3:38 PM

Izno edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.

Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jan 2 2019, 12:24 AM

Krinkle moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.

Change 484179 had a related patch set uploaded (by Umherirrender; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/OAuthAuthentication@master] Fix test setup using the getTestUser() infrastructure

https://gerrit.wikimedia.org/r/484179

gerritbot added a project: Patch-For-Review.Jan 14 2019, 5:41 PM

Umherirrender closed this task as Resolved.Jan 14 2019, 5:48 PM

Umherirrender assigned this task to thiemowmde.

Umherirrender triaged this task as Medium priority.

Change 484179 merged by jenkins-bot:
[mediawiki/extensions/OAuthAuthentication@master] Fix test setup using the getTestUser() infrastructure

https://gerrit.wikimedia.org/r/484179

thiemowmde awarded a token.Jan 15 2019, 8:37 AM