Page MenuHomePhabricator
Create Task
Maniphest T209304

[Bug] Date span dash missing in TOC
Closed, ResolvedPublic
Actions

Description

image1 (5).png (1×2 px, 2 MB)

From OTRS ticket: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10868548

Steps to reproduce
Search for the City and South London Railway article
Scroll down to the section Extensions to the Clapham... and note that the section header includes a dash between the dates
Open the TOC

Expected results
The TOC presents the date span as 1890-1901

Actual results
The TOC presents the date span as 18901901

Reproduce-able?
Reproducible on an iPhone X

Event Timeline

cmadeo created this task.Nov 12 2018, 7:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2018, 7:30 PM
cmadeo removed a parent task: T209168: Wikitext editing tools .Nov 13 2018, 3:55 PM
• JMinor triaged this task as Medium priority.Nov 19 2018, 7:43 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor added a project: iOS-app-v6.2-Beluga-On-A-Pogo-Stick.
cmadeo removed cmadeo as the assignee of this task.Nov 26 2018, 7:40 PM
LGoto moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Nov 26 2018, 7:41 PM
Mhurd claimed this task.Nov 26 2018, 11:00 PM
Mhurd moved this task from Ready for Development to Doing on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.
Mhurd added a comment.Nov 26 2018, 11:15 PM

https://github.com/wikimedia/wikipedia-ios/pull/2788

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Nov 26 2018, 11:15 PM
Mhurd moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Dec 6 2018, 8:42 PM
JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Jan 8 2019, 7:10 PM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Jan 14 2019, 4:10 PM
cmadeo added a project: Product-QA.

Looks good to me! Thanks @Mhurd!

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.2-Beluga-On-A-Pogo-Stick board.Jan 22 2019, 11:36 PM
ABorbaWMF subscribed.

Looking good on phone and tablet on 6.2.0 (1563)

• JMinor closed this task as Resolved.Jan 24 2019, 12:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL