Page MenuHomePhabricator

Tracker returns 500 instead of 404 when trying to edit non-existent ticket in admin
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Ensure you're logged in with admin account.
  2. Go to /admin/tracker/ticket/1555555/ (the number should not match ID of any existing ticket)
  3. You will be shown 500 Internal Error
  4. 404 Not Found error is expected

Traceback

Internal Server Error: /admin/tracker/ticket/15555/
Traceback (most recent call last):
  File "/var/www/tracker.wikimedia.cz/deploy/pyenv/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/var/www/tracker.wikimedia.cz/deploy/pyenv/lib/python2.7/site-packages/django/contrib/admin/options.py", line 618, in wrapper
    return self.admin_site.admin_view(view)(*args, **kwargs)
  File "/var/www/tracker.wikimedia.cz/deploy/pyenv/lib/python2.7/site-packages/django/utils/decorators.py", line 110, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/var/www/tracker.wikimedia.cz/deploy/pyenv/lib/python2.7/site-packages/django/views/decorators/cache.py", line 57, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/var/www/tracker.wikimedia.cz/deploy/pyenv/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 233, in inner
    return view(request, *args, **kwargs)
  File "./tracker/admin.py", line 55, in change_view
    extra_context['user_can_edit_documents'] = ticket.can_edit_documents(request.user)
AttributeError: 'NoneType' object has no attribute 'can_edit_documents'

Event Timeline

rafidaslam subscribed.

I'll work on this (claimed on gci)

Change 473635 had a related patch set uploaded (by Rafidaslam; owner: Rafid Aslam):
[wikimedia-cz/tracker@master] Return 404 when trying to edit non-existent ticket in admin

https://gerrit.wikimedia.org/r/473635

Change 473635 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Return 404 when trying to edit non-existent ticket in admin

https://gerrit.wikimedia.org/r/473635