Page MenuHomePhabricator
Create Task
Maniphest T209346

If a user's file was moved to Commons, their account should be autocreated
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Motivation
When users' files are moved to Commons, they lose the track history of the file in the original wiki. However, it is super important, to keep the files in their contribution lists. The files usually appear in the Commons contribution lists, but in order for that to happen, the user needs to have a commons account.
In T199076 we had argued that the user should not be autocreated for an action that they did not perform. However, it is more important to keep the contribution record than a maybe surprising autcreation.
Right now, user links are in plain text, or redirect to the home wiki if possible.

Acceptance Criteria

  • If the uploader of a file that was moved to Commons does not have a Commons account, it is created for the uploader, and connected to their global account.
  • This also affects all other editors of the file who don't yet have a Commons account

Notes
For now, we are only talking about the page history, not file revision history.
Ideally, there should be an integration test for this.

  • The file history links to the uploader's Commons user page.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/FileImportermaster+30 -2Always try to create users in target wiki
Customize query in gerrit

Related Objects

Event Timeline

Lea_WMDE created this task.Nov 13 2018, 10:27 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptNov 13 2018, 10:27 AM
Lea_WMDE renamed this task from I a user's file was moved to Commons, their account should be autocreated to If a user's file was moved to Commons, their account should be autocreated.Nov 13 2018, 10:28 AM
Lea_WMDE triaged this task as Medium priority.
Lea_WMDE mentioned this in T199076: Moving a file to Commons should not auto-create a Commons user account for the original uploader of the file.
Lea_WMDE updated the task description. (Show Details)Nov 13 2018, 2:09 PM
Lea_WMDE set the point value for this task to 5.
Lea_WMDE mentioned this in T199110: Show imported files / file pages in users' special pages in target wiki.Nov 13 2018, 2:21 PM
thiemowmde added a project: WMDE-QWERTY-Sprint-2018-11-20.Nov 20 2018, 12:52 PM
thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.
thiemowmde added subscribers: thiemowmde, WMDE-Fisch.
WMDE-Fisch moved this task from Tickets in preparation/investigation to Tickets in sprint on the Move-Files-To-Commons board.Nov 20 2018, 12:57 PM
WMDE-Fisch claimed this task.Nov 20 2018, 3:14 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-11-20 board.
gerritbot added a subscriber: gerritbot.Nov 20 2018, 5:13 PM

Change 474952 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Always try to create users in target wiki

https://gerrit.wikimedia.org/r/474952

gerritbot added a project: Patch-For-Review.Nov 20 2018, 5:13 PM
WMDE-Fisch mentioned this in rEFLI51ed170b7132: Always try to create users in target wiki.Nov 20 2018, 5:31 PM
Pikne added a subscriber: Pikne.Nov 20 2018, 6:25 PM

Isn't this already the case? I'm pretty sure I've triggered account creation for several users, e.g. for this user when importing this file.

WMDE-Fisch added a comment.Nov 21 2018, 10:11 AM
In T209346#4763237, @Pikne wrote:

Isn't this already the case? I'm pretty sure I've triggered account creation for several users, e.g. for this user when importing this file.

Yeah you're kind of right ;-). - It was the case, then we changed it to not having autocreate and now we came to the conclusion that having the account creation is overall the better option. :-)

WMDE-Fisch mentioned this in rEFLIe0f19a0eaf9e: Always try to create users in target wiki.Nov 21 2018, 12:04 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-11-20 board.Nov 21 2018, 12:08 PM
Pikne added a comment.Nov 21 2018, 12:27 PM
In T209346#4765264, @WMDE-Fisch wrote:
In T209346#4763237, @Pikne wrote:

Isn't this already the case? I'm pretty sure I've triggered account creation for several users, e.g. for this user when importing this file.

Yeah you're kind of right ;-). - It was the case, then we changed it to not having autocreate and now we came to the conclusion that having the account creation is overall the better option. :-)

Maybe it's helpful or maybe it isn't: I tried this out and I just triggered account creation for this user.

WMDE-Fisch mentioned this in rEFLI2a040286e8d0: Always try to create users in target wiki.Nov 21 2018, 1:45 PM
gerritbot added a comment.Nov 21 2018, 1:57 PM

Change 474952 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Always try to create users in target wiki

https://gerrit.wikimedia.org/r/474952

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 21 2018, 2:00 PM
WMDE-Fisch added a comment.Nov 21 2018, 2:36 PM
In T209346#4765665, @Pikne wrote:

Maybe it's helpful or maybe it isn't: I tried this out and I just triggered account creation for this user.

Yeah looking at it more in detail, that also seems to be true. For file revisions the process was a bit different indeed and it seems that we there still autocreated these accounts there. Well with this patch autocreation will be handled the same for file and text revisions and more importantly we associate the created revisions with the Commons user account. :-)

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-11-20 board.Nov 21 2018, 5:51 PM
JJMC89 added a subscriber: JJMC89.Nov 21 2018, 9:01 PM
In T209346#4765900, @WMDE-Fisch wrote:

with this patch autocreation will be handled the same for file and text revisions and more importantly we associate the created revisions with the Commons user account. :-)

I wasn't using the importer much due to imported revisions not being associated with Common's accounts. Thanks for fixing it.

Is there a script (or another method) for associating revisions have already been imported?

WMDE-Fisch added a comment.Nov 22 2018, 9:44 AM
In T209346#4766737, @JJMC89 wrote:
In T209346#4765900, @WMDE-Fisch wrote:

with this patch autocreation will be handled the same for file and text revisions and more importantly we associate the created revisions with the Commons user account. :-)

I wasn't using the importer much due to imported revisions not being associated with Common's accounts. Thanks for fixing it.

Is there a script (or another method) for associating revisions have already been imported?

No, at the moment there is no script I know of that does that. - The only way I can think of to doing this right now would be deleting the files on Commons and re-importing them. :-/ ( when the patch is deployed )

WMDE-Fisch added a comment.Nov 23 2018, 8:34 AM

I tested this on beta with a user that did not exist before import on beta commons and was auto created [1] with the import [2].

[1] https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Log?type=newusers&user=&page=JogoBot
[2] https://commons.wikimedia.beta.wmflabs.org/wiki/File:TEST_Euro_exchange_rate_to_TRY_-_Turkish_Currency_and_Debt_Crisis_2018.svg

WMDE-Fisch added a comment.Dec 3 2018, 11:02 AM

Beta fully works again now: 2nd test set:

Import:
https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Screen_Shot_2018-10-29_at_2.24.02_PM.png&action=history
User creation:
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Log?type=newusers&user=&page=Test-apples&wpdate=&tagfilter=&subtype=
User contribution:
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Contributions/Test-apples

Here we even have:

Import Log (new):
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Log?type=import&user=&page=File%3AScreen+Shot+2018-10-29+at+2.24.02+PM.png&wpdate=&tagfilter=&subtype=
Upload Log (still part of investigations):
https://commons.wikimedia.beta.wmflabs.org/wiki/Special:Log?type=upload&user=&page=File%3AScreen+Shot+2018-10-29+at+2.24.02+PM.png&wpdate=&tagfilter=&subtype=

Lea_WMDE closed this task as Resolved.Dec 3 2018, 12:55 PM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-11-20 board.
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 3:15 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL