Page MenuHomePhabricator

Mobile edits not logged in EditAttemptStep schema
Closed, ResolvedPublic

Description

The following query in the Data Lake should tally number of events logged by the platform (desktop, tablet, phone, other) for the EditAttemptStep schema:

SELECT event.platform, count(*) AS num_events
FROM event.editattemptstep
WHERE year=2018 AND month=11 GROUP BY event.platform;

However, the query only finds events for the desktop platform, as seen in this output from running it shortly before writing this task:

platform	num_events
desktop	1674894
Time taken: 34.216 seconds, Fetched: 1 row(s)

Running a comparable query over the most recent data for the Edit schema in the log database results in events for several platforms:

SELECT event_platform, count(*) AS num_events
FROM Edit_17541122
WHERE timestamp >= '20181001000000' AND timestamp < '20181101000000'
GROUP BY event_platform;
+----------------+------------+
| event_platform | num_events |
+----------------+------------+
| desktop        |   10976304 |
| other          |          4 |
| phone          |    2113612 |
+----------------+------------+
3 rows in set (1 min 27.60 sec)

So, is mobile edit events logged for the EditAttemptStep schema?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2018, 11:26 PM

Change 473317 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@master] Fix EditAttemptStepSamplingRate variable export

https://gerrit.wikimedia.org/r/473317

Change 473319 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep.js: Use correct config var name for sampling rate

https://gerrit.wikimedia.org/r/473319

Change 473319 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] schemaEditAttemptStep.js: Use correct config var name for sampling rate

https://gerrit.wikimedia.org/r/473319

Change 473317 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Fix EditAttemptStepSamplingRate variable export

https://gerrit.wikimedia.org/r/473317

Change 473394 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] Fix EditAttemptStepSamplingRate variable export

https://gerrit.wikimedia.org/r/473394

Change 473395 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.4] schemaEditAttemptStep.js: Use correct config var name for sampling rate

https://gerrit.wikimedia.org/r/473395

Change 473394 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] Fix EditAttemptStepSamplingRate variable export

https://gerrit.wikimedia.org/r/473394

Change 473395 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.4] schemaEditAttemptStep.js: Use correct config var name for sampling rate

https://gerrit.wikimedia.org/r/473395

SBisson moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.
Etonkovidova closed this task as Resolved.Nov 20 2018, 1:11 AM
Etonkovidova added a subscriber: Etonkovidova.

From log db in betalabs - the mobile events have been recorded (and single events were verified for completeness too).

MariaDB [log]> select event_platform, event_action, count(*) as number  from EditAttemptStep_18530416 group by event_platform, event_action order by number desc;
+----------------+--------------+--------+
| event_platform | event_action | number |
+----------------+--------------+--------+
| desktop        | init         |     52 |
| desktop        | loaded       |     30 |
| desktop        | ready        |     30 |
| desktop        | saveAttempt  |     30 |
| desktop        | saveSuccess  |     24 |
| desktop        | saveIntent   |     18 |
| desktop        | abort        |      8 |
| phone          | ready        |      8 |
| desktop        | saveFailure  |      6 |
| phone          | init         |      6 |
| phone          | saveIntent   |      2 |
| phone          | saveAttempt  |      2 |
| phone          | saveSuccess  |      2 |
| phone          | abort        |      1 |
+----------------+--------------+--------+
14 rows in set (0.01 sec)