Page MenuHomePhabricator

PHPUnit: Cover 2 methods in MobileFrontend.body.php
Open, LowPublic

Description

The class in MobileFrontend.body.php file has no code coverage. Tests should be written to fix this.

Methods to be covered are;

  • ExtMobileFrontend::getWikibaseEntity()
  • ExtMobileFrontend::getWikibaseDescription()

Acceptance criteria

  • Write unit tests to cover 2 methods in MobileFrontend.body.php mentioned above.
  • Code coverage report has gone up.

Event Timeline

D3r1ck01 triaged this task as Normal priority.
D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.Nov 14 2018, 12:14 PM

Change 473483 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add unit tests for ExtMobileFrontend::class

https://gerrit.wikimedia.org/r/473483

D3r1ck01 removed D3r1ck01 as the assignee of this task.Nov 15 2018, 10:47 AM
D3r1ck01 moved this task from Doing [WIP] to Backlog on the User-D3r1ck01 board.

Moving this to Radar, will come back to it later :)

D3r1ck01 raised the priority of this task from Normal to Needs Triage.Nov 15 2018, 10:47 AM
Jdlrobson triaged this task as Low priority.

Please re-add patch-for-review when you want a new round of review!

Change 473483 abandoned by D3r1ck01:
Add unit tests for ExtMobileFrontend::class

Reason:
very useful reviews, will come back to this later.

https://gerrit.wikimedia.org/r/473483