Page MenuHomePhabricator

PHPUnit: Cover 2 methods in MobileFrontend.body.php
Open, LowPublic

Description

The class in MobileFrontend.body.php file has no code coverage. Tests should be written to fix this.

Methods to be covered are;

  • ExtMobileFrontend::getWikibaseEntity()
  • ExtMobileFrontend::getWikibaseDescription()

Acceptance criteria

  • Write unit tests to cover 2 methods in MobileFrontend.body.php mentioned above.
  • Code coverage report has gone up.

Event Timeline

xSavitar triaged this task as Medium priority.Nov 14 2018, 12:00 PM
xSavitar created this task.

Change 473483 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add unit tests for ExtMobileFrontend::class

https://gerrit.wikimedia.org/r/473483

xSavitar moved this task from Doing [WIP] to Backlog on the User-xSavitar board.

Moving this to Radar, will come back to it later :)

xSavitar raised the priority of this task from Medium to Needs Triage.Nov 15 2018, 10:47 AM

Please re-add patch-for-review when you want a new round of review!

Change 473483 abandoned by D3r1ck01:
Add unit tests for ExtMobileFrontend::class

Reason:
very useful reviews, will come back to this later.

https://gerrit.wikimedia.org/r/473483

Is this task still a goal of yours D3r1ck?

Is this task still a goal of yours D3r1ck?

Yes, this is still under my radar. I'll pick it up soon!