Maniphest T209490

Date field will be prefilled with invalid date on Special:Log if 0000 is submitted
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Nov 14 2018, 2:22 PM

Description

Steps to reproduce:

Go to Special:Log
Put your name in performer field. Hit show. This causes you to go to the page https://meta.wikimedia.org/wiki/Special:Log?type=&user=Bawolff&page=&wpdate=0000-00-00&tagfilter=
The date field is now set to -0001-11-30. This is invalid. When i change something else and hit submit i get a pre-submit client side error

Details

	Subject	Repo	Branch	Lines +/-
	LogEventsList: Don't output '0000-00-00' as default date	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW38756eae46a8: Special:Log: Convert to HTMLForm
rMWf198154d7678: SpecialLog: Don't throw exceptions on invalid date from user input
T117737: Convert Special:Log to OOUI
T201411: Fatal error on Special:Log caused by date input (TimestampException error)

Event Timeline

Bawolff created this task.Nov 14 2018, 2:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2018, 2:22 PM

Looks like @Legoktm fixed the server side part of this in f198154d76782 / T201411 but the client side error is still present.

Possibly regression from 38756eae46a87c / T117737

If I go to html source view-source:https://meta.wikimedia.org/wiki/Special:Log?type=&user=Bawolff&page=&wpdate=0000-00-00&tagfilter=

<tr class="mw-htmlform-field-HTMLDateTimeField mw-htmlform-datetime-field"><td class="mw-label"><label for="mw-input-wpdate">From date (and earlier):</label></td><td class="mw-input"><input id="mw-input-wpdate" name="wpdate" size="45" value="-0001-11-30" class="mw-htmlform-datetime-field" placeholder="YYYY-MM-DD" step="1" pattern="[0-9]{4}-[01][0-9]-[0-3][0-9]" type="date"/>
</td></tr>

So maybe other browsers are ignoring the invalid html default value, but mine is not

Change 473527 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] LogEventsList: Don't output '0000-00-00' as default date

https://gerrit.wikimedia.org/r/473527

gerritbot added a project: Patch-For-Review.Nov 14 2018, 2:51 PM

Change 473527 merged by jenkins-bot:
[mediawiki/core@master] LogEventsList: Don't output '0000-00-00' as default date

https://gerrit.wikimedia.org/r/473527

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 4:00 PM

matmarex closed this task as Resolved.Nov 14 2018, 4:11 PM

matmarex claimed this task.

matmarex removed a project: Patch-For-Review.