Page MenuHomePhabricator

Captions editor should behave better when the API gives us an HTML error response
Closed, ResolvedPublic

Description

[Proposing as a blocker.]

In testing T208771: Ensure ConfirmEdit applies when the context is an MCR page, I found two not-great outcomes.

If your edit is hard-blocked, it doesn't save (good), you get a response shown as an error (good), but it escapes the HTML rather than rendering it:

If your edit is CAPTCHA-blocked, I imagine it does the same thing, so it won't show the CAPTCHA or its input box and won't let you submit that (though I couldn't trigger that behaviour).

Event Timeline

Change 473772 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Render errors from api as html

https://gerrit.wikimedia.org/r/473772

Change 473772 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Render errors from api as html

https://gerrit.wikimedia.org/r/473772

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Nov 15 2018, 9:34 PM
Ramsey-WMF closed this task as Resolved.Dec 3 2018, 5:27 PM