| Jdforrester-WMF | |
| Nov 14 2018, 4:31 PM |
| F27220842: image.png | |
| Nov 14 2018, 4:31 PM |
[Proposing as a blocker.]
In testing T208771: Ensure ConfirmEdit applies when the context is an MCR page, I found two not-great outcomes.
If your edit is hard-blocked, it doesn't save (good), you get a response shown as an error (good), but it escapes the HTML rather than rendering it:
If your edit is CAPTCHA-blocked, I imagine it does the same thing, so it won't show the CAPTCHA or its input box and won't let you submit that (though I couldn't trigger that behaviour).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Render errors from api as html | mediawiki/extensions/WikibaseMediaInfo | master | +1 -1 |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | • Ramsey-WMF | T205732 Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions) | ||
| Resolved | Cparle | T209502 Captions editor should behave better when the API gives us an HTML error response | ||
| · · · |
Change 473772 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Render errors from api as html
Change 473772 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Render errors from api as html