Page MenuHomePhabricator

In a multi-part judgment, can one of the parts be null?
Closed, DeclinedPublic

Description

A patch was recently merged to Jade https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JADE/+/466781/ that requires that, for a Jade judgment schema with multiple parts (damaging and goodfaith, in this case), that both options are selected and neither is null.

My concern with this is that it puts a burden on the user to render an opinion they don't have. If I'm a recent changes patroller and I have lots of other edits to go through, I might only complete one of the parts for expediency's sake. If I am forced to complete both parts, I would probably just give up and end up delivering no data.

Considering this, do we want to proceed with this requirement?

Event Timeline

Harej triaged this task as Medium priority.Nov 14 2018, 11:12 PM

@Halfak We need your feedback here. All I remember from IRC was that you wanted "not null" validation, but don't know what your reasoning is.

Hey! Yes. So I believe that no one intentionally selects "null" in Wikilabels. The "nulls" we get are when information is unavailable (e.g. the revision was deleted). "null" doesn't carry the meaning we'd like when someone is filing an endorsement. Does it mean "I agree that we shouldn't be judging the 'damaging'ness of this edit."? Probably not. It seems to me that if we want to have an explicit "too difficult to say" option, we should add that to the schema rather than allowing for "null"s and assuming their meaning.

As discussed in last week's Scoring Staff meeting, the issue is that semantically, "null" doesn't mean "I don't know" – it means "there is no data." So we need a more explicit "I don't know" indicator.

From Etherpad:

Reasons why someone might not want to confidently submit damaging/goodfaith together:

  • Don't want to judge "goodfaith"
  • Don't know for sure
  • OK with making a judgment but I want someone else to review it

Declining "null" parameters in favor of the approach in T208820. For now, this means that both damaging and goodfaith fields are required.