Page MenuHomePhabricator

Remove unnecessary wrapper div from .vectorMenu's overflow menu
Closed, ResolvedPublic

Description

The wrapper div might have had some functionality in the far past (cross-browser rendering?), it's simply unnecessary back to IE 7 at least, as the ul itself is able to be positioned equally.

Current source:

<div class="menu">
	<ul>
		<li id="ca-move"><a href="/wiki/Special:MovePage/Front_end" title="Rename this page [ctrl-option-m]" accesskey="m">Move</a></li>
	</ul>
</div>

Expected source

<ul class="menu">
	<li id="ca-move"><a href="/wiki/Special:MovePage/Front_end" title="Rename this page [ctrl-option-m]" accesskey="m">Move</a></li>
</ul>

Event Timeline

Volker_E created this task.Nov 15 2018, 4:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2018, 4:38 AM

Change 473651 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] Remove unnecessary div wrapper on overflow menu

https://gerrit.wikimedia.org/r/473651

Change 473651 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove unnecessary div wrapper on overflow menu

https://gerrit.wikimedia.org/r/473651

I would expect this change to break tools that create additional menus, like Twinkle and MoreMenu.

matmarex closed this task as Resolved.May 22 2019, 5:11 PM

Well, I guess it did not break anything after all…