| Tchanders | |
| Nov 15 2018, 3:55 PM |
| F28969931: ve_block.png | |
| May 8 2019, 5:34 PM |
| F27653731: image.png | |
| Dec 19 2018, 10:20 PM |
On mobile visual editor, if a blocked user tries to edit a page (or a partially blocked user tries to edit a page they are blocked from), they are not told that they are blocked until after attempting to save the page.
On desktop visual editor, an edit notice appears as soon as the editor opens, warning them that they are blocked.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T221328 [Epic] Mobile VE usability improvements (FY18-19 Q4) | |||
| Open | ppelberg | T221185 Prepare visual editor to be a default mobile editor | |||
| Resolved | matmarex | T220011 Show anonymous/blocked editor prompts for VE mobile as well as wikitext mobile editors | |||
| Resolved | ppelberg | T209599 Show block notices on mobile visual editor |
This is actually not a big problem because if you're blocked, then the mobile site doesn't let you open the editor at all. When clicking on the "Edit" icon, a popup like this opens instead of the editor:
However, this can be bypassed by viewing a veaction=edit URL (e.g. https://en.m.wikipedia.org/wiki/The_Fighting_Temeraire?veaction=edit), which is probably a separate bug.
Change 506467 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Show block notice in VE
Change 507375 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Return structured block info as well as formatted notice
Change 507375 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Return structured block info as well as formatted notice
Change 506467 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Show block notice in VE
If I try to load visual editor on a page from which I am blocked, I get:
Error loading data from server: HTTP 500. Would you like to retry?
For a brief time yesterday, when I did the same thing the error was something like: "Call to private method ApiQueryUserInfo::getBlockInfo from ApiVisualEditor", but not today.
Looks like this method has been removed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506945…
Change 508915 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Fix use of getBlockInfo()
Change 508915 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Fix use of getBlockInfo()
Change 508941 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.4] ApiVisualEditor: Fix use of getBlockInfo()
Change 508941 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.34.0-wmf.4] ApiVisualEditor: Fix use of getBlockInfo()
Mentioned in SAL (#wikimedia-operations) [2019-05-08T21:58:03Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: UBN T209599 ApiVisualEditor: Fix use of getBlockInfo() (duration: 00m 57s)
@dom_walden Thank you for noticing this! It should be displaying an appropriate message again now (on both desktop and mobile).
@matmarex for future reference, how do you go about testing patches that apply to contributors who are blocked?
I tested it on my local MediaWiki installation, where I created and blocked a user account. If you'd like to test it, I can give your account on https://en.wikipedia.beta.wmflabs.org/ the ability to block users (or I can just block it), just message me and tell me the username.