Page MenuHomePhabricator
Create Task
Maniphest T209600

The #pos parser function will throw E_WARNING if the offset is longer than the string.
Closed, ResolvedPublic
Actions

Description

The mb_strpos() function throws E_WARNING if the offset is longer than the length of the string. This change takes the shorter of the two integers.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ParserFunctions/+/473768/

Details

SubjectRepoBranchLines +/-
Fix E_WARNING with {{#pos:}} if the offset is larger than the stringmediawiki/extensions/ParserFunctionsREL1_31+19 -1
Fix E_WARNING with {{#pos:}} if the offset is larger than the stringmediawiki/extensions/ParserFunctionsREL1_32+19 -1
Fix E_WARNING with {{#pos:}} if the offset is larger than the stringmediawiki/extensions/ParserFunctionsmaster+19 -1
Customize query in gerrit

Event Timeline

Alexia created this task.Nov 15 2018, 4:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2018, 4:13 PM
gerritbot subscribed.Nov 15 2018, 8:42 PM

Change 473768 had a related patch set uploaded (by Legoktm; owner: Alexia):
[mediawiki/extensions/ParserFunctions@master] The mb_strpos() function throws E_WARNING if the offset is longer than the length of the string.

https://gerrit.wikimedia.org/r/473768

gerritbot added a project: Patch-For-Review.Nov 15 2018, 8:42 PM
Legoktm assigned this task to Alexia.Dec 20 2018, 3:24 AM
Legoktm added projects: MW-1.31-release, MW-1.32-release.
Legoktm subscribed.

Should be trivial to backport...

gerritbot added a comment.Dec 20 2018, 3:35 AM

Change 473768 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Fix E_WARNING with {{#pos:}} if the offset is larger than the string

https://gerrit.wikimedia.org/r/473768

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 20 2018, 4:00 AM
gerritbot added a comment.Dec 20 2018, 4:09 AM

Change 480898 had a related patch set uploaded (by Legoktm; owner: Alexia):
[mediawiki/extensions/ParserFunctions@REL1_32] Fix E_WARNING with {{#pos:}} if the offset is larger than the string

https://gerrit.wikimedia.org/r/480898

gerritbot added a comment.Dec 20 2018, 4:09 AM

Change 480899 had a related patch set uploaded (by Legoktm; owner: Alexia):
[mediawiki/extensions/ParserFunctions@REL1_31] Fix E_WARNING with {{#pos:}} if the offset is larger than the string

https://gerrit.wikimedia.org/r/480899

gerritbot added a comment.Dec 20 2018, 4:15 AM

Change 480898 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@REL1_32] Fix E_WARNING with {{#pos:}} if the offset is larger than the string

https://gerrit.wikimedia.org/r/480898

gerritbot added a comment.Dec 20 2018, 4:15 AM

Change 480899 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@REL1_31] Fix E_WARNING with {{#pos:}} if the offset is larger than the string

https://gerrit.wikimedia.org/r/480899

Legoktm closed this task as Resolved.Dec 20 2018, 4:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits