Page MenuHomePhabricator

On mobile, template context menu doesn't show the name of the template
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Nov 15 2018, 5:40 PM
Referenced Files
F27854824: image.png
Jan 11 2019, 2:41 PM
F27854833: image.png
Jan 11 2019, 2:41 PM
F27854836: image.png
Jan 11 2019, 2:41 PM
F27854756: image.png
Jan 11 2019, 2:27 PM
F27854760: image.png
Jan 11 2019, 2:27 PM
F27232370: image.png
Nov 15 2018, 5:45 PM
F27232283: image.png
Nov 15 2018, 5:45 PM
F27232374: image.png
Nov 15 2018, 5:45 PM

Description

On mobile, template context menu doesn't show the name of the template – depending on your screen size, the description is cut off after the "Generated from:" label. On the smallest devices even that label is partially cut off.

image.png (568×320 px, 115 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I suggest that we just remove that prefix… I think it was meant to better explain the situation where one "transclusion" is generated from multiple "templates" (e.g. Col-begin + Col-break + Col-end), but I think it is not very useful even in that case.

BeforeAfter
image.png (568×320 px, 115 KB)
image.png (568×320 px, 115 KB)

We could keep that prefix on desktop, or just remove it there as well for consistency and simplicity:

BeforeAfter
image.png (379×1 px, 127 KB)
image.png (379×1 px, 127 KB)

Change 473821 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTransclusionContextItem: Remove "Generated from" prefix from description

https://gerrit.wikimedia.org/r/473821

I think the desktop version should have more verbose description, in some cases the template name itself could read like a message and so could be misleading without some context showing it is just a template name, e.g.

image.png (139×444 px, 10 KB)

image.png (147×439 px, 5 KB)

It would also be nice to show templatedata descriptions in the context when available. Our original designs had even more descriptive labels, which would probably require extra templatedata: https://commons.wikimedia.org/wiki/File:VisualEditor_context_designs_2015.png

Compare with the dialog, which doesn't show the word "Template" anywhere:

image.png (122×523 px, 10 KB)

With this design the context would look more like this:

beforeafter
image.png (118×407 px, 7 KB)
image.png (123×418 px, 9 KB)

...with some sort of fallback for templates without templatedata descriptions.

I think the desktop version should have more verbose description, in some cases the template name itself could read like a message and so could be misleading without some context showing it is just a template name (…)

I don't really feel like this would be an issue. I think the "Template" heading provides enough context?

If it was a problem, I would rather solve it by making the template names links to their description pages, similar to our handling of media.

It would also be nice to show templatedata descriptions in the context when available. Our original designs had even more descriptive labels, which would probably require extra templatedata: https://commons.wikimedia.org/wiki/File:VisualEditor_context_designs_2015.png

Seems cute, but out of scope? D:

Compare with the dialog, which doesn't show the word "Template" anywhere:

I've always found this a bit weird, to be honest. The actual template name is repeated anyway just below the dialog head.

Change 473821 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTransclusionContextItem: Remove "Generated from" prefix from description (mobile)

https://gerrit.wikimedia.org/r/473821

Change 488580 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTransclusionContextItem: Use the right class name in override

https://gerrit.wikimedia.org/r/488580

Change 488580 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTransclusionContextItem: Use the right class name in override

https://gerrit.wikimedia.org/r/488580

Change 488592 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.16] ve.ui.MWTransclusionContextItem: Use the right class name in override

https://gerrit.wikimedia.org/r/488592

Change 488592 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.16] ve.ui.MWTransclusionContextItem: Use the right class name in override

https://gerrit.wikimedia.org/r/488592

Mentioned in SAL (#wikimedia-operations) [2019-02-07T00:53:08Z] <twentyafterfour@deploy1001> Synchronized php-1.33.0-wmf.16/extensions/VisualEditor/: SWAT rEVEDf89e12fc466d to fix bug: T209610 (duration: 00m 55s)

@Pginer-WMF Note that in the final version of the patch, we only removed the "Generated from:" prefix on mobile VE, and left it unchanged on desktop. If you want to pursue getting rid of it on desktop as well (which I support, but you'll have to convince @Esanders), please reopen T199923 :)