Page MenuHomePhabricator

SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension
Closed, ResolvedPublic

Description

A risky test in the Collection extension.

There was 1 risky test:

1) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "Book" (SpecialCollection Object (...))
Test code or tested code did not (only) close its own output buffers

Also failed in ElectronPdfService, because it needs Collection extension.

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/13038/consoleFull

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2018, 5:59 PM
Umherirrender renamed this task from Collection extensions has unstable php7 tests in gate-and-submit to SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension.Nov 15 2018, 6:02 PM
Umherirrender updated the task description. (Show Details)

Change 484230 had a related patch set uploaded (by Umherirrender; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Collection@master] Remove bad calls to QuickTemplate::msgWiki() to fix tests

https://gerrit.wikimedia.org/r/484230

Change 484230 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Remove bad calls to QuickTemplate::msgWiki() to fix tests

https://gerrit.wikimedia.org/r/484230

Umherirrender closed this task as Resolved.Jan 15 2019, 7:40 PM
Umherirrender assigned this task to thiemowmde.
Umherirrender triaged this task as Normal priority.