Maniphest T209661

The transclusion/template dialog's Apply changes action is always enabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Nov 15 2018, 11:35 PM

Description

The transclusion/template dialog's Apply changes action is always enabled.

Details

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button	mediawiki/extensions/VisualEditor	master	+11 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		matmarex	T206000 Apply changes action is enabled on several dialogs before any changes are made
		Resolved		matmarex	T209661 The transclusion/template dialog's Apply changes action is always enabled

Event Timeline

matmarex created this task.Nov 15 2018, 11:35 PM

matmarex mentioned this in T206000: Apply changes action is enabled on several dialogs before any changes are made.

Change 473957 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button

https://gerrit.wikimedia.org/r/473957

gerritbot added a project: Patch-For-Review.Nov 16 2018, 12:11 AM

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Nov 16 2018, 12:12 AM

Change 473957 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplateDialog: Unbreak the logic to enable/disable "Apply" button

https://gerrit.wikimedia.org/r/473957

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 19 2018, 6:00 PM

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 19 2018, 6:11 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Templates; removed Patch-For-Review.Nov 19 2018, 6:24 PM

Ryasmeen added a project: Editing QA.Nov 26 2018, 6:53 PM

matmarex mentioned this in T210686: [Regression pre-wmf.8] Typing in any fields for Cite>Web/Book etc. disables the "Insert" field.Nov 29 2018, 3:53 AM

Ryasmeen added a project: Verified.Nov 29 2018, 10:49 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Ryasmeen removed a project: Editing QA.Nov 29 2018, 10:52 PM

• marcella closed this task as Resolved.Dec 14 2018, 4:17 PM