Page MenuHomePhabricator

Partially blocked admins should be able to restore revisions of deleted pages
Open, LowestPublic

Description

Just tested on thegoodplace on Thursday, Nov 15: https://thegoodplace.wmflabs.org/index.php?title=Special:Undelete&target=Cheese You need admin permissions to view the page.

Admins can now delete pages outside of their partial block (T208274), but cannot restore pages outside their partial block. They can view the 'View deleted pages' at Special:Undelete but cannot perform the restore action.

Here is what it looks like for PB'd admins:

Here is what it looks like for admins who are not PB'd — and what it should look like for admins who are PB'd.


Acceptance criteria

  • Partially blocked admins should be able to restore revisions of deleted pages, as if they were not blocked at all.
  • TBD: Partially blocked admins should not be able to restore revisions of deleted pages if the page is configured in their partial block — if possible, depending on the state of a partial block for a deleted page.

Event Timeline

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 15 2018, 11:35 PM

We'll also want to QA suppressed content, which should also be reversible. I'm not sure which environment this is available on -- probably beta -- but requires advanced permissions to test.

@TBolliger is this a regression? (i.e. is this a problem on testwiki right now?)

On test wiki, the undelete page is entirely inaccessible to PB'd admins:

thegoodplace allows for admins to delete pages outside their PB and view the undelete page for all pages. I'm not sure I'd call this a regression but its also not the long-term acceptable functionality.

TBolliger updated the task description. (Show Details)Nov 29 2018, 6:22 PM

Might be fixed by T209097

TBolliger lowered the priority of this task from Low to Lowest.Jan 30 2019, 10:12 PM
TBolliger removed a project: Anti-Harassment.