Maniphest T209687

WikibaseMediaInfo should define keys to ignore when passing test to AbuseFilter
Closed, ResolvedPublic
Actions

Description

WikibaseMediaInfo should define array keys of the JSON serialization of MediaInfo entities to be ignored when passing text to EditFilters / Abuse Filters.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/474135/ allows configuration of this within the MediaInfo Content object (this was previously hard coded in EntityContent).

This should be done before deploying MediaInfo to commons to avoid having to do something like T205254 as we will have to do for wikidata.org

Tagging Performance as this will improve performance of MediaInfo edits dramatically (as entities get bigger) See T204109#4602542

Related Objects

Mentioned In: rEWBI2a6b03c52ec1: Set out which entity keys should be ignored for AbuseFilter
rEWBIc7a0e26aaaba: Set out which entity keys should be ignored for AbuseFilter
rEWBI3b947b821ee9: Set out which entity keys should be ignored for AbuseFilter
rEWBIe7a30ec7b138: Set out which entity keys should be ignored for AbuseFilter
rEWBI3ce802ed0e25: Set out which entity keys should be ignored for AbuseFilter
rEWBI287f86b3feb6: Set out which entity keys should be ignored for AbuseFilter
T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions)
Mentioned Here: T204109: Investigate some Wikidata write api queries taking over 30 seconds. (In EntityContent::collectValues?)
T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org

Event Timeline

• Addshore created this task.Nov 16 2018, 9:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2018, 9:34 AM

• Addshore added a project: Performance.Nov 16 2018, 9:35 AM

• Addshore updated the task description. (Show Details)

• Addshore added a subscriber: Cparle.

Jdforrester-WMF mentioned this in T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions).Nov 16 2018, 7:44 PM

This should really be done ASAP.
Otherwise all abusefilters on commons will have to be checked before removing things from the text provided to the filters.

AF is dark magic. What exactly is being exposed now, that we can drop?

Change 483301 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Set out which entity keys should be ignored for AbuseFilter

https://gerrit.wikimedia.org/r/483301

gerritbot added a project: Patch-For-Review.Jan 9 2019, 10:36 PM

Jdforrester-WMF mentioned this in rEWBI287f86b3feb6: Set out which entity keys should be ignored for AbuseFilter.Jan 9 2019, 10:39 PM

For reference the links I gave James in IRC were https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/tests/phpunit/mediawiki/Content/MediaInfoContentTest.php#L161, https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/tests/phpunit/mediawiki/Content/textForFilters.txt and https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/src/Content/MediaInfoContent.php#L54-L56

Jdforrester-WMF mentioned this in rEWBI3ce802ed0e25: Set out which entity keys should be ignored for AbuseFilter.Jan 9 2019, 10:54 PM

In T209687#4867773, @Jdforrester-WMF wrote:

AF is dark magic.

If you have specific questions you may want to ask @Daimona who's been very active on AF lately and not CC'ed here.

I have alerts for all AF tasks, so I have actually read this, and I'll be glad to help :)

Jdforrester-WMF edited projects, added SDC Engineering; removed StructuredDataOnCommons.Jan 14 2019, 10:26 PM

Jdforrester-WMF claimed this task.

Jdforrester-WMF moved this task from To Do to Doing on the SDC Engineering board.

Jdforrester-WMF moved this task from Backlog to Deployment and configuration on the AbuseFilter board.

Jdforrester-WMF mentioned this in rEWBIe7a30ec7b138: Set out which entity keys should be ignored for AbuseFilter.Jan 14 2019, 10:57 PM

• Addshore mentioned this in rEWBI3b947b821ee9: Set out which entity keys should be ignored for AbuseFilter.Jan 15 2019, 6:02 PM

• Addshore mentioned this in rEWBIc7a0e26aaaba: Set out which entity keys should be ignored for AbuseFilter.Jan 15 2019, 6:06 PM

Change 483301 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Set out which entity keys should be ignored for AbuseFilter

https://gerrit.wikimedia.org/r/483301

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.14; 2019-01-22); removed Patch-For-Review.Jan 15 2019, 7:39 PM

Jdforrester-WMF moved this task from Doing to Verify on Production on the SDC Engineering board.

This code has been merged. Can @Daimona and/or @Addshore test and confirm it's working as intended?

Wednesday, February 20th, 2019
10:18 AM — cormacparle_ waves
10:18 AM <cormacparle_ Wanna close this, that ok? https://phabricator.wikimedia.org/T209687
10:18 AM <addshore> *looks*
10:18 AM sounds good to me
10:18 AM <cormacparle_> ace, ta

greg added a project: Multimedia.Mar 7 2019, 10:59 PM

jijiki mentioned this in rEWBI2a6b03c52ec1: Set out which entity keys should be ignored for AbuseFilter.Mar 18 2019, 4:26 PM

WikibaseMediaInfo should define keys to ignore when passing test to AbuseFilterClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

WikibaseMediaInfo should define keys to ignore when passing test to AbuseFilter
Closed, ResolvedPublic
Actions