Maniphest T209702

Edit icon in new two column edit conflict design appears active when it can't be edited
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	Dvorapa
	Nov 16 2018, 1:55 PM

Description

Steps to reproduce

Get into an edit conflict with the beta feature on (or just look on this image: https://commons.wikimedia.org/wiki/File:New_design_for_the_Two_Column_edit_conflict_interface,_status_October_2018.png)
Choose a version (e.g. before) and try to click to the pencil icon in the other version.

Expected behavior
The icon shouldn't be there or should open an edit dialog

Current behavior
The icon does nothing instead, which was really confusing to me

My first experience with the new design
I've chosen left (his) version and tried to click to a pencil icon in the right version (not noticed the same icon in the left version). Nothing happenned. I was confused, tried to click the icon multiple times unable to edit anything. I solved my first experience by leaving the interface. Next time I noticed the second identical pencil icon.

Details

	Subject	Repo	Branch	Lines +/-
	Make disabled edit pen lighter	mediawiki/extensions/TwoColConflict	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T245410: Neither column of a conflict should be selected by default
Mentioned Here: T246878: [UX investigation] Change interaction pattern for selecting versions

Event Timeline

Dvorapa created this task.Nov 16 2018, 1:55 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptNov 16 2018, 1:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Dvorapa updated the task description. (Show Details)Nov 16 2018, 1:55 PM

Dvorapa added a parent task: T195711: Make v2 of TwoColConflict: line based edit conflict handling.Nov 16 2018, 2:25 PM

WMDE-Fisch removed a parent task: T195711: Make v2 of TwoColConflict: line based edit conflict handling.Jan 30 2020, 3:43 PM

I'll check the color of the icon and investigate if the edit pen needs to remain or can go away.

Lena_WMDE moved this task from Backlog to Before full default on the Two-Column-Edit-Conflict-Merge board.Feb 18 2020, 9:02 AM

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-02-19.Feb 19 2020, 11:08 AM

awight mentioned this in T245410: Neither column of a conflict should be selected by default.Feb 19 2020, 11:08 AM

thiemowmde moved this task from Before full default to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Feb 19 2020, 11:11 AM

awight added a project: WMDE-Design.Feb 19 2020, 11:25 AM

Restricted Application added a project: Design. · View Herald TranscriptFeb 19 2020, 11:25 AM

Erdinc_Ciftci_WMDE subscribed.Feb 25 2020, 12:49 PM

This comment was removed by Erdinc_Ciftci_WMDE.

thiemowmde claimed this task.Mar 2 2020, 9:22 AM

thiemowmde removed thiemowmde as the assignee of this task.

thiemowmde claimed this task.

thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-02-19 board.

thiemowmde subscribed.

Change 575988 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] [POC] Replace custom "disabled" colors with opacity

https://gerrit.wikimedia.org/r/575988

gerritbot added a project: Patch-For-Review.Mar 2 2020, 10:00 AM

Current colors for comparison:

Screenshot from 2020-03-02 10-42-56.png (90×946 px, 12 KB)

Proposed colors as of patch https://gerrit.wikimedia.org/r/575988, patch set 1:

Screenshot from 2020-03-02 10-43-19.png (90×939 px, 12 KB)

@Hanna_Petruschat_WMDE, note this is really just meant as a proof-of-concept to achieve two things: To understand what code we need to touch, and to have something visually we can talk about. Please let us know what best to do with disabled edit pen buttons.

Hi @thiemowmde,

for a quick fix I would suggest to set the color of the disabled edit pen to Base50 (#a2a9b1). No matter which way we choose we always violate the style guide (Base30) or code suggestions (0.51). Our interaction pattern just doesn't fit in the use cases they consider, but I would not like to make it a necessary change for this task.

I set up another ticket where we can discuss going for another interaction pattern which might help people understand what they are supposed or unable to do: T246878

Done: https://gerrit.wikimedia.org/r/575988

awight removed • Hanna_Petruschat_WMDE as the assignee of this task.Mar 4 2020, 10:48 AM

awight added a project: WMDE-QWERTY-Sprint-2020-03-04.

awight set the point value for this task to 1.

awight moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-03-04 board.

Change 575988 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Make disabled edit pen lighter

https://gerrit.wikimedia.org/r/575988

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 4 2020, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2020, 1:10 PM

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-03-04 board.Mar 5 2020, 8:07 AM

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:00 PM

thiemowmde renamed this task from New two column edit conflict design should not contain edit icon when it can't be edited to Edit icon in new two column edit conflict design appears active when it can't be edited.Mar 17 2020, 12:43 PM

thiemowmde closed this task as Resolved.

thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-03-04 board.

	F31654856: Screenshot from 2020-03-02 10-42-56.png
	Mar 2 2020, 10:05 AM

	F31654855: Screenshot from 2020-03-02 10-43-19.png
	Mar 2 2020, 10:05 AM

Edit icon in new two column edit conflict design appears active when it can't be editedClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Edit icon in new two column edit conflict design appears active when it can't be edited
Closed, ResolvedPublic1 Estimated Story Points
Actions