Page MenuHomePhabricator

New two column edit conflict design should not contain edit icon when it can't be edited
Open, Needs TriagePublic

Description

Steps to reproduce

  1. Get into an edit conflict with the beta feature on (or just look on this image: https://commons.wikimedia.org/wiki/File:New_design_for_the_Two_Column_edit_conflict_interface,_status_October_2018.png)
  2. Choose a version (e.g. before) and try to click to the pencil icon in the other version.

Expected behavior
The icon shouldn't be there or should open an edit dialog

Current behavior
The icon does nothing instead, which was really confusing to me

My first experience with the new design
I've chosen left (his) version and tried to click to a pencil icon in the right version (not noticed the same icon in the left version). Nothing happenned. I was confused, tried to click the icon multiple times unable to edit anything. I solved my first experience by leaving the interface. Next time I noticed the second identical pencil icon.

Event Timeline

Dvorapa created this task.Nov 16 2018, 1:55 PM
Restricted Application added a project: TCB-Team. · View Herald TranscriptNov 16 2018, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dvorapa updated the task description. (Show Details)Nov 16 2018, 1:55 PM