Page MenuHomePhabricator

PHPUnit: Cover all features/Feature class methods
Closed, ResolvedPublic

Description

The class in features/Feature.php file has no code coverage. Tests should be written to fix this.

Acceptance criteria

  • Write unit tests to cover all methods in /features/Feature.php.
  • Code coverage report has gone up - 100%

Event Timeline

D3r1ck01 created this task.Nov 16 2018, 4:57 PM
D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.

Change 474300 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add FeatureTest test class to test Feature::class

https://gerrit.wikimedia.org/r/474300

D3r1ck01 claimed this task.Nov 16 2018, 5:52 PM

Change 474300 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add FeatureTest test class to test Feature::class

https://gerrit.wikimedia.org/r/474300

Jdlrobson closed this task as Resolved.Nov 16 2018, 11:26 PM

Hurrah! Good job!

Thanks for your guide and assistance @Jdlrobson. Thank you :)

Thanks for your guide and assistance @Jdlrobson. Thank you :)

This is looking nice: https://doc.wikimedia.org/cover-extensions/MobileFrontend/features/index.html :), we're at 29% overall now from 27% (so +2%), cool :)