Maniphest T209765

PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class
Closed, ResolvedPublic
Actions

Description

The test method for getPluralLicenseInfo() in MobileFrontendSkinHooks class doesn't cover the null cases. According to the code coverage report, the current test for this method doesn't execute that code. Covering it.

Code snippet

else {
    $delimiterMsg = wfMessage( 'and' );
}

Acceptance Criteria

Code coverage has gone up (getPluralLicenseInfo() method covered 100%)
Else code path covered
Null cases covered

Details

	Subject	Repo	Branch	Lines +/-
	MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj	mediawiki/extensions/MobileFrontend	master	+22 -9
	Cover the NULL cases in getPluralLicenseInfo() unit test	mediawiki/extensions/MobileFrontend	master	+5 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
		Resolved		None	T209765 PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class

Event Timeline

xSavitar triaged this task as Medium priority.Nov 17 2018, 2:18 PM

xSavitar created this task.

Change 474462 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Cover the NULL in MobileFrontendSkinHooksTest

https://gerrit.wikimedia.org/r/474462

gerritbot added a project: Patch-For-Review.Nov 17 2018, 2:18 PM

xSavitar moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 17 2018, 2:19 PM

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

xSavitar updated the task description. (Show Details)Nov 17 2018, 2:24 PM

xSavitar updated the task description. (Show Details)Nov 17 2018, 2:34 PM

xSavitar moved this task from Doing [WIP] to Completed (To be Resolved) on the User-xSavitar board.

Change 474462 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Cover the NULL cases in getPluralLicenseInfo() unit test

https://gerrit.wikimedia.org/r/474462

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 18 2018, 10:00 AM

xSavitar moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 18 2018, 10:19 AM

Code coverage has gone up

Finding coverage difference in cb0bc3bfb9f946caf90755345928d80135638182
$ php7.0 -d zend_extension=xdebug.so "$MW_INSTALL_PATH"/tests/phpunit/phpunit.php --coverage-clover /tmp/clovertu70If --filter '/MobileFrontend\.skin\.hooksTest/'
Using PHP 7.0.30-0+deb9u1
PHPUnit 6.5.13 by Sebastian Bergmann and contributors.



Time: 10.34 seconds, Memory: 308.00MB

No tests executed!

Generating code coverage report in Clover XML format ... done
$ php7.0 -d zend_extension=xdebug.so "$MW_INSTALL_PATH"/tests/phpunit/phpunit.php --coverage-clover /tmp/cloveryxI6tH --filter '/MobileFrontend\.skin\.hooksTest/'
Using PHP 7.0.30-0+deb9u1
PHPUnit 6.5.13 by Sebastian Bergmann and contributors.



Time: 10.16 seconds, Memory: 308.00MB

No tests executed!

Generating code coverage report in Clover XML format ... done
No coverage changes found.

It looks like the test (tests/phpunit/MobileFrontend.skin.hooksTest.php) is actually filtered out.

phuedx moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 19 2018, 2:26 PM

xSavitar removed a project: Patch-For-Review.Nov 19 2018, 5:41 PM

xSavitar moved this task from Completed (To be Resolved) to Backlog on the User-xSavitar board.

xSavitar removed a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 19 2018, 10:24 PM

Pulling out of sprint, but this is not completed yet.

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Nov 20 2018, 9:47 PM

Jdlrobson moved this task from Needs Prioritization to Tracking on the Web-Team-Backlog board.Nov 22 2018, 4:31 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

Will pick this up again soonish :)

xSavitar raised the priority of this task from Medium to Needs Triage.Dec 22 2018, 6:10 PM

Change 486248 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj

https://gerrit.wikimedia.org/r/486248

gerritbot added a project: Patch-For-Review.Jan 24 2019, 10:32 AM

xSavitar claimed this task.Jan 24 2019, 10:37 AM

xSavitar triaged this task as Medium priority.

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.Jan 24 2019, 2:00 PM

xSavitar edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Web-Team-Backlog (Tracking).

xSavitar moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 24 2019, 6:07 PM

Change 486248 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj

https://gerrit.wikimedia.org/r/486248

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 24 2019, 7:00 PM