Page MenuHomePhabricator

Switch to using ULS as a backend for languages instead of using the ULS dialog
Open, LowPublic

Description

VE uses the ULS as a backend instead of using the ULS dialog. The dialog is not as glamorous. Here's a screenshot from what VE has -

image.png (790×1 px, 88 KB)

This task is to integrate that into the Language settings dialog instead of the ULS.

Event Timeline

Niharika triaged this task as Medium priority.Nov 20 2018, 12:43 AM
Niharika created this task.

@Mooeypoo Created this ticket per our discussion.

@Prtksxna We'd need a design for this. :) Feel free to shoot me any questions you may have. I created this ticket because Moriel raised a bunch of accessibility and design issues with ULS.

@Samwilson @aezell Flagging this for you too.

I am guessing that we'd need to display, and allow to search using the following:

  1. Language name in the UI language - अंग्रेज़ी (English, in Hindi, and written in Devanagari)
  2. Language name in the language itself - English
  3. Language code in latin - en

Do we have this data? Are we able to search and autocomplete using all three? Assuming we can, I propose that we don't have a separate dialog for this, instead have a menu that could work with both dropdown and tag select widgets. The label could be in the format:

Language name in UI language (Language name in the language itself).........code
English (English)...........................................................en
Hindi (हिन्दी).................................................................hi
Urdu (اُردُو‬‎).................................................................ur
Japanese (日本語)............................................................ja
etc.
DropdownTagMultiselect
dropdown.png (246×721 px, 26 KB)
tagmultiselect.png (177×723 px, 19 KB)

@Mooeypoo, could you share some of your a11y and design concerns?

Is this task for replacing ULS for all three of its usages in SVG Translate: interface language, preferred languages, and target language?

@Samwilson Good question. My understanding from talking to @Mooeypoo is that this is a somewhat trivial amount of work and would increase accessibility and stability. I was initially thinking of pushing this back until we know for sure that ULS does not meet our needs but if it is not a lot of work, I'd prefer to replace ULS everywhere as Moriel recommended. If you want to skip the work of integrating ULS in places you haven't yet, that is probably okay.

This is a future enhancement for sure, not really something we should deal with for the MVP.

That said, I think that if we go this route, we can assess the different widgets as we go; there are cases where ULS dialog is perfectly suitable (like the button-clicks that choose a single language) and cases where the use might not be as great (like drop downs and multiselect)

In the cases where we encounter issues with using the ULS dialog, using the backend-data is a good idea -- which is what this ticket is for.

Niharika lowered the priority of this task from Medium to Low.Nov 26 2018, 10:35 PM
Niharika moved this task from Backlog to Wishful thinking on the SVG Translate Tool board.

Okay. Based on what you wrote above, @Mooeypoo, I'm putting this ticket on the back burner for now. Let's use ULS as in the prototype and we can look into this post-MVP.

@Samwilson @Prtksxna ^ Sorry about the mix-up. Let's go with ULS for now as planned.