Page MenuHomePhabricator
Create Task
Maniphest T209932

Update mediawiki eslint config
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In T207169 we added eslint-plugin-compat to our eslint config, but that didn't catch all IE11 incompatibilities. We also discovered that wikimedia was in the process of updating their eslint configuration to ensure compatibility with IE11. This process is finished now (see #113) and we should update the eslint config in our projects to use the new mediawiki config. See their README.

Note: eslint-config-wikimedia v0.9.0 is now released!

Acceptance criteria:

  • Wikibase extends mediawiki/client
  • WikibaseLexeme extends mediawiki/client
  • WikibaseQualityConstraints extends mediawiki/client
  • WikimediaBadges extends mediawiki/client
  • PropertySuggester extends mediawiki/client

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseQualityConstraintsmaster+6 -5Update upstream wikimedia eslint config
mediawiki/extensions/WikibaseLexememaster+9 -2Update upstream wikimedia eslint config
mediawiki/extensions/Wikibasemaster+20 -5Update upstream wikimedia eslint config
mediawiki/extensions/WikimediaBadgesmaster+2 -2Update upstream wikimedia eslint config
mediawiki/extensions/PropertySuggestermaster+2 -2Update upstream wikimedia eslint config
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Nov 20 2018, 11:22 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptNov 20 2018, 11:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Michael moved this task from Ready to estimate to Needs Work on the Wikidata-Campsite board.Nov 20 2018, 11:23 AM
Michael added a project: JavaScript.Nov 20 2018, 11:26 AM
Michael updated the task description. (Show Details)
Michael updated the task description. (Show Details)Nov 20 2018, 1:19 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Nov 20 2018, 6:29 PM
Jdforrester-WMF added a comment.Nov 20 2018, 9:46 PM

eslint-config-wikimedia v0.9.0 is now released.

xSavitar awarded a token.Nov 20 2018, 9:47 PM
• Addshore triaged this task as Medium priority.Nov 21 2018, 8:21 AM
• Addshore moved this task from incoming to consider for next sprint on the Wikidata board.
• Addshore updated the task description. (Show Details)
• Addshore moved this task from Needs Work to Ready to estimate on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Nov 27 2018, 2:12 PM
Lucas_Werkmeister_WMDE set the point value for this task to 3.
Michael claimed this task.Nov 29 2018, 2:22 PM
Restricted Application added a project: User-Michael. · View Herald TranscriptNov 29 2018, 2:22 PM
Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 29 2018, 2:22 PM
Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.
gerritbot added a subscriber: gerritbot.Nov 29 2018, 3:41 PM

Change 476529 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476529

gerritbot added a project: Patch-For-Review.Nov 29 2018, 3:41 PM
gerritbot added a comment.Nov 29 2018, 4:07 PM

Change 476538 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476538

gerritbot added a comment.Nov 29 2018, 4:07 PM

Change 476539 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476539

Michael mentioned this in T210744: Refactor our javascript to remove jquery usage with better vanilla alternatives.Nov 29 2018, 4:08 PM
Michael mentioned this in rEWLEa47f40aab501: Update upstream wikimedia eslint config.Nov 29 2018, 4:09 PM
gerritbot added a comment.Nov 29 2018, 4:22 PM

Change 476543 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikimediaBadges@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476543

gerritbot added a comment.Nov 29 2018, 4:30 PM

Change 476544 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/PropertySuggester@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476544

Michael updated the task description. (Show Details)Nov 29 2018, 4:44 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael moved this task from ⏳ In progress to 💬 waiting on other's work or feedback on the User-Michael board.Nov 29 2018, 4:46 PM
Michael added a comment.Nov 29 2018, 4:49 PM

The new release of the wikimedia config also disallows a number of jQuery methods. I didn't implement these changes in this ticket, but created T210744 to discuss and estimate them. This only affects Wikibase and WikibaseLexeme.

Michael added a comment.Nov 29 2018, 4:50 PM

Also a noticed that today a new version of wikimedia stylelint was released. Do we want to pull that version as well in a new ticket?

Michael mentioned this in rEPSf5ee49c598f1: Update upstream wikimedia eslint config.Nov 29 2018, 5:08 PM
gerritbot added a comment.Nov 30 2018, 7:40 AM

Change 476544 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476544

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 30 2018, 8:00 AM
gerritbot added a comment.Nov 30 2018, 9:09 AM

Change 476543 merged by Michael Große:
[mediawiki/extensions/WikimediaBadges@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476543

gerritbot added a comment.Nov 30 2018, 12:23 PM

Change 476529 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476529

gerritbot added a comment.Nov 30 2018, 2:35 PM

Change 476539 merged by Michael Große:
[mediawiki/extensions/WikibaseLexeme@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476539

gerritbot added a comment.Nov 30 2018, 3:18 PM

Change 476538 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Update upstream wikimedia eslint config

https://gerrit.wikimedia.org/r/476538

Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 30 2018, 3:20 PM
Jdforrester-WMF added a comment.Nov 30 2018, 6:38 PM

LGTM. Thanks!

Michael moved this task from 💬 waiting on other's work or feedback to ✅ my work done on the User-Michael board.Dec 3 2018, 3:04 PM
• Addshore closed this task as Resolved.Dec 13 2018, 5:31 PM
• Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Michael mentioned this in rEWLEaae764f8e8e6: Renable and fix max-statements-per-line eslint rule.Dec 20 2018, 4:23 PM
Michael mentioned this in rEWLE907f98ca9ed8: Renable and fix max-statements-per-line eslint rule.Dec 21 2018, 11:22 AM
Michael mentioned this in rEWLE12d46752e0e9: Renable and fix max-statements-per-line eslint rule.Jan 2 2019, 10:57 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL