Page MenuHomePhabricator

Use lookup() instead of hiera() in Puppet
Closed, ResolvedPublic

Details

ProjectBranchLines +/-Subject
operations/puppet-lint/wmf_styleguide-checkmaster+111 -41
operations/puppetproduction+5 -2
operations/puppetproduction+6 -1
operations/puppetproduction+6 -1
operations/puppetproduction+6 -5
integration/configmaster+1 -1
integration/configmaster+7 -0
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+8 -8
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+3 -3
operations/puppetproduction+4 -4
operations/puppetproduction+12 -12
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+6 -6
operations/puppetproduction+21 -25
operations/puppetproduction+3 -3
operations/puppetproduction+1 -1
operations/puppetproduction+10 -10
operations/puppetproduction+10 -10
operations/puppetproduction+3 -3
operations/puppetproduction+2 -2
operations/puppetproduction+3 -2
operations/puppetproduction+5 -5
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+4 -4
operations/puppetproduction+1 -1
operations/puppetproduction+3 -3
operations/puppetproduction+8 -8
operations/puppetproduction+5 -5
operations/puppetproduction+2 -1
operations/puppetproduction+10 -10
operations/puppetproduction+15 -15
operations/puppetproduction+10 -10
operations/puppetproduction+1 -1
operations/puppetproduction+32 -22
operations/puppetproduction+4 -4
operations/puppetproduction+6 -6
operations/puppetproduction+4 -4
operations/puppetproduction+7 -7
operations/puppetproduction+7 -7
operations/puppetproduction+7 -7
operations/puppetproduction+6 -6
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+4 -4
operations/puppetproduction+31 -30
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+20 -20
operations/puppetproduction+5 -5
operations/puppetproduction+11 -11
operations/puppetproduction+9 -9
operations/puppetproduction+10 -10
operations/puppetproduction+22 -6
operations/puppetproduction+2 -2
operations/puppetproduction+3 -3
operations/puppetproduction+4 -4
operations/puppetproduction+7 -1
operations/puppetproduction+16 -16
operations/puppetproduction+14 -14
operations/puppetproduction+6 -6
operations/puppetproduction+22 -22
operations/puppetproduction+10 -10
operations/puppetproduction+13 -13
operations/puppetproduction+5 -5
operations/puppetproduction+2 -2
operations/puppetproduction+6 -6
operations/puppetproduction+9 -8
operations/puppetproduction+12 -12
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+7 -7
operations/puppetproduction+13 -13
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+25 -25
operations/puppetproduction+4 -4
operations/puppetproduction+1 -1
operations/puppetproduction+13 -13
operations/puppetproduction+12 -12
operations/puppetproduction+9 -9
operations/puppetproduction+412 -412
operations/puppetproduction+8 -8
operations/puppetproduction+2 -2
operations/puppetproduction+5 -5
operations/puppetproduction+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 657045 merged by Elukey:
[operations/puppet@production] eventlogging: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657045

Change 657047 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] kafka: Use lookup() instead of hiera() in code comment

https://gerrit.wikimedia.org/r/657047

Change 657047 merged by Elukey:
[operations/puppet@production] kafka: Use lookup() instead of hiera() in code comment

https://gerrit.wikimedia.org/r/657047

Change 657044 merged by Gehel:
[operations/puppet@production] query_service: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657044

Change 657040 merged by Jcrespo:
[operations/puppet@production] bacula: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657040

Change 657363 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] refinery: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657363

Change 657364 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] analytics: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657364

Change 657364 merged by Elukey:
[operations/puppet@production] analytics: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657364

Change 655518 merged by Dzahn:
[operations/puppet@production] redis::slave: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/655518

Change 655516 merged by Dzahn:
[operations/puppet@production] monitoring::host: move hostgroup_default to params, hiera->lookup

https://gerrit.wikimedia.org/r/655516

Change 657363 merged by Elukey:
[operations/puppet@production] refinery: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657363

Change 657560 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] logstash: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657560

Change 657958 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes

https://gerrit.wikimedia.org/r/657958

Change 658079 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cache: Migrate hiera() to lookup() and set datatypes in frontend

https://gerrit.wikimedia.org/r/658079

Change 657958 merged by Vgutierrez:
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes

https://gerrit.wikimedia.org/r/657958

Change 658079 merged by Vgutierrez:
[operations/puppet@production] cache: Migrate hiera() to lookup() and set datatypes in frontend

https://gerrit.wikimedia.org/r/658079

Change 657560 merged by Filippo Giunchedi:
[operations/puppet@production] logstash: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657560

Change 658397 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs primary

https://gerrit.wikimedia.org/r/658397

Dzahn updated the task description. (Show Details)

Change 658503 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] Migrate hiera() to lookup() and set datatypes in purge.pp

https://gerrit.wikimedia.org/r/658503

Change 658503 merged by Vgutierrez:
[operations/puppet@production] Migrate hiera() to lookup() and set datatypes in purge.pp

https://gerrit.wikimedia.org/r/658503

Change 658397 merged by Bstorm:
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs primary

https://gerrit.wikimedia.org/r/658397

Change 659048 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] etcd::replication: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659048

Change 655508 merged by Dzahn:
[operations/puppet@production] profile::base: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/655508

Change 659048 merged by Dzahn:
[operations/puppet@production] etcd::replication: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659048

Change 659071 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] base::certificates: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/659071

Change 659073 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] tlsproxy::prometheus: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/659073

Change 659140 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes in realserver

https://gerrit.wikimedia.org/r/659140

Change 659141 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] wmcs: Migrate hiera() to lookup() in nfsclient

https://gerrit.wikimedia.org/r/659141

Change 659140 merged by Giuseppe Lavagetto:
[operations/puppet@production] lvs: Migrate hiera() to lookup() in realserver

https://gerrit.wikimedia.org/r/659140

Change 659336 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs secondary

https://gerrit.wikimedia.org/r/659336

Change 659073 merged by Dzahn:
[operations/puppet@production] tlsproxy::prometheus: hiera->lookup

https://gerrit.wikimedia.org/r/659073

Change 659380 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::kubernetes::deployment_server::helmfile: hiera -> lookup

https://gerrit.wikimedia.org/r/659380

Change 659075 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] monitoring::service: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659075

Change 659381 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::docker::storage::thinpool: hiera -> lookup

https://gerrit.wikimedia.org/r/659381

Change 659389 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::kubernetes::node: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659389

Change 659392 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::redis::multidc: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659392

Change 659400 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::rsyslog::udp_localhost_compat: hiera -> lookup

https://gerrit.wikimedia.org/r/659400

Change 659401 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::rsyslog::netdev_kafka_relay: hiera -> lookup

https://gerrit.wikimedia.org/r/659401

Change 659404 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] role::postgres::master: hiera -> lookup

https://gerrit.wikimedia.org/r/659404

Change 659141 merged by Bstorm:
[operations/puppet@production] wmcs: Migrate hiera() to lookup() in nfsclient

https://gerrit.wikimedia.org/r/659141

Change 659336 merged by Bstorm:
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs secondary

https://gerrit.wikimedia.org/r/659336

Change 659389 merged by Alexandros Kosiaris:
[operations/puppet@production] profile::kubernetes::node: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659389

Change 659380 merged by Alexandros Kosiaris:
[operations/puppet@production] profile::kubernetes::deployment_server::helmfile: hiera -> lookup

https://gerrit.wikimedia.org/r/659380

Change 659381 merged by Alexandros Kosiaris:
[operations/puppet@production] profile::docker::storage::thinpool: hiera -> lookup

https://gerrit.wikimedia.org/r/659381

Change 659789 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet-lint/wmf_styleguide-check@master] Add check to error when calling to hiera()

https://gerrit.wikimedia.org/r/659789

Change 659075 merged by Dzahn:
[operations/puppet@production] monitoring::service: hiera -> lookup

https://gerrit.wikimedia.org/r/659075

Change 659071 merged by Dzahn:
[operations/puppet@production] base::certificates: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/659071

Change 659401 merged by Dzahn:
[operations/puppet@production] profile::rsyslog::netdev_kafka_relay: hiera -> lookup

https://gerrit.wikimedia.org/r/659401

Change 659400 merged by Dzahn:
[operations/puppet@production] profile::rsyslog::udp_localhost_compat: hiera -> lookup

https://gerrit.wikimedia.org/r/659400

Change 659404 merged by Dzahn:
[operations/puppet@production] role::postgres::master: hiera -> lookup

https://gerrit.wikimedia.org/r/659404

Change 660951 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::docker::storage::loopback: hiera -> lookup

https://gerrit.wikimedia.org/r/660951

Change 660953 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] labs_bootstrapvz: hiera -> lookup

https://gerrit.wikimedia.org/r/660953

Change 661070 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] tlsproxy::localssl hiera->lookup

https://gerrit.wikimedia.org/r/661070

Change 660951 merged by Dzahn:
[operations/puppet@production] profile::docker::storage::loopback: hiera -> lookup

https://gerrit.wikimedia.org/r/660951

Change 659392 merged by Dzahn:
[operations/puppet@production] profile::redis::multidc: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/659392

Change 660953 merged by Dzahn:
[operations/puppet@production] labs_bootstrapvz: hiera -> lookup

https://gerrit.wikimedia.org/r/660953

Change 661070 merged by Vgutierrez:
[operations/puppet@production] tlsproxy::localssl hiera->lookup

https://gerrit.wikimedia.org/r/661070

Change 661916 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] ldap: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/661916

Change 662008 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] grafana: replace hiera inside hiera with lookup

https://gerrit.wikimedia.org/r/662008

Change 662013 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] netmon: replace hiera within hiera with lookup

https://gerrit.wikimedia.org/r/662013

Change 662021 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] hieradata/common: replace hiera within hiera with lookup

https://gerrit.wikimedia.org/r/662021

Change 662022 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] netbox: replace hiera inside hiera with lookup

https://gerrit.wikimedia.org/r/662022

Change 662026 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] wmcs::monitoring: replace hiera inside hiera with lookup

https://gerrit.wikimedia.org/r/662026

Change 662033 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::rsyslog::udp_json_logback_compat: hiera -> lookup

https://gerrit.wikimedia.org/r/662033

Change 662033 merged by Dzahn:
[operations/puppet@production] profile::rsyslog::udp_json_logback_compat: hiera -> lookup

https://gerrit.wikimedia.org/r/662033

Change 662008 merged by Dzahn:
[operations/puppet@production] grafana: replace hiera inside hiera with lookup

https://gerrit.wikimedia.org/r/662008

Change 662013 merged by Dzahn:
[operations/puppet@production] netmon: replace hiera within hiera with lookup

https://gerrit.wikimedia.org/r/662013

Change 662022 merged by Dzahn:
[operations/puppet@production] netbox: replace hiera inside hiera with lookup

https://gerrit.wikimedia.org/r/662022

Change 662021 merged by Dzahn:
[operations/puppet@production] hieradata/common: replace hiera within hiera with lookup

https://gerrit.wikimedia.org/r/662021

Change 662026 merged by Dzahn:
[operations/puppet@production] wmcs::monitoring: replace hiera inside hiera with lookup

https://gerrit.wikimedia.org/r/662026

Change 661916 merged by Dzahn:
[operations/puppet@production] ldap: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/661916

This would be done if it wasn't for a single remaining case:

Could you guys fix this one please?

62 puppetmaster::servers:
63   "%{hiera('puppetmaster')}":
64     - { worker: "%{hiera('puppetmaster')}", loadfactor: 10 }
65

Change 663289 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] cloud: replace hiera in hiera with lookup

https://gerrit.wikimedia.org/r/663289

Change 663289 merged by Dzahn:
[operations/puppet@production] cloud: replace hiera in hiera with lookup

https://gerrit.wikimedia.org/r/663289

Dzahn edited projects, added Epic; removed Patch-For-Review.
Dzahn added a subscriber: jbond.

After many many patches this is now actually DONE!

No more hiera() in any .pp file across the entire operations/puppet.

https://docs.google.com/spreadsheets/d/1mSy8EGvbHinxBy2CqsPfhO3udYEUPyx2f4DzI1xTNx4/edit?usp=sharing

Special thanks to @Ladsgroup and @jbond

Change 659789 merged by Jbond:
[operations/puppet-lint/wmf_styleguide-check@master] Add check to error when calling to hiera()

https://gerrit.wikimedia.org/r/659789

Change 664297 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] Gemfile: increase dependency for wmf_style-stylegude-check

https://gerrit.wikimedia.org/r/664297

Change 664298 had a related patch set uploaded (by Jbond; owner: John Bond):
[integration/config@master] operations/puppet: update to pick up new wmf_style-stylegudie-check

https://gerrit.wikimedia.org/r/664298

Change 664297 merged by Jbond:
[operations/puppet@production] Gemfile: increase dependency for wmf_style-stylegude-check

https://gerrit.wikimedia.org/r/664297

Change 664298 merged by jenkins-bot:
[integration/config@master] operations/puppet: update to pick up new wmf_style-stylegudie-check

https://gerrit.wikimedia.org/r/664298

Mentioned in SAL (#wikimedia-releng) [2021-02-15T15:58:46Z] <hashar> Successfully published image docker-registry.discovery.wmnet/releng/operations-puppet:0.8.1 # T209953

Change 664305 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] jjb: bump puppet image

https://gerrit.wikimedia.org/r/664305

Change 664305 merged by jenkins-bot:
[integration/config@master] jjb: bump puppet image

https://gerrit.wikimedia.org/r/664305

Change 665459 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] docker::engine: replace hiera_hash with lookup with hash merge behaviour

https://gerrit.wikimedia.org/r/665459

Change 665461 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup

https://gerrit.wikimedia.org/r/665461

Change 665462 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::wmcs::instance: replace hiera_include with lookup

https://gerrit.wikimedia.org/r/665462

Change 665461 merged by Dzahn:
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup

https://gerrit.wikimedia.org/r/665461

Change 665459 merged by Dzahn:
[operations/puppet@production] docker::engine: replace hiera_hash with lookup, add data types

https://gerrit.wikimedia.org/r/665459

Change 668507 had a related patch set uploaded (by Jbond; owner: Jbond):
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup

https://gerrit.wikimedia.org/r/668507

Change 668507 merged by Dzahn:
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup

https://gerrit.wikimedia.org/r/668507

Change 665462 merged by Andrew Bogott:
[operations/puppet@production] profile::wmcs::instance: replace hiera_include with lookup

https://gerrit.wikimedia.org/r/665462