Page MenuHomePhabricator

Use lookup() instead of hiera() in Puppet
Open, LowPublic

Description

hiera() functions have been deprecated and will be removed in Puppet 6:

https://puppet.com/docs/puppet/5.1/hiera_migrate_functions.html
https://puppet.com/docs/puppet/5.5/hiera_migrate.html#updated-classic-hiera-function-calls

Future-proof code by switching to lookup() now

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+3 -3
operations/puppetproduction+10 -10
operations/puppetproduction+2 -2
operations/puppetproduction+3 -2
operations/puppetproduction+5 -5
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+4 -4
operations/puppetproduction+1 -1
operations/puppetproduction+3 -3
operations/puppetproduction+8 -8
operations/puppetproduction+5 -5
operations/puppetproduction+2 -1
operations/puppetproduction+10 -10
operations/puppetproduction+21 -25
operations/puppetproduction+15 -15
operations/puppetproduction+10 -10
operations/puppetproduction+1 -1
operations/puppetproduction+32 -22
operations/puppetproduction+4 -4
operations/puppetproduction+6 -6
operations/puppetproduction+4 -4
operations/puppetproduction+7 -7
operations/puppetproduction+7 -7
operations/puppetproduction+7 -7
operations/puppetproduction+6 -6
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+4 -4
operations/puppetproduction+31 -30
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+20 -20
operations/puppetproduction+5 -5
operations/puppetproduction+11 -11
operations/puppetproduction+9 -9
operations/puppetproduction+10 -10
operations/puppetproduction+22 -6
operations/puppetproduction+2 -2
operations/puppetproduction+3 -3
operations/puppetproduction+4 -4
operations/puppetproduction+7 -1
operations/puppetproduction+16 -16
operations/puppetproduction+14 -14
operations/puppetproduction+6 -6
operations/puppetproduction+22 -22
operations/puppetproduction+10 -10
operations/puppetproduction+13 -13
operations/puppetproduction+5 -5
operations/puppetproduction+2 -2
operations/puppetproduction+6 -6
operations/puppetproduction+9 -8
operations/puppetproduction+12 -12
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+7 -7
operations/puppetproduction+13 -13
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+25 -25
operations/puppetproduction+4 -4
operations/puppetproduction+1 -1
operations/puppetproduction+13 -13
operations/puppetproduction+12 -12
operations/puppetproduction+9 -9
operations/puppetproduction+412 -412
operations/puppetproduction+8 -8
operations/puppetproduction+2 -2
operations/puppetproduction+5 -5
operations/puppetproduction+1 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 644363 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] k8s: replace hiera with lookup

https://gerrit.wikimedia.org/r/644363

Change 644770 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] hadoop: Migrate hiera() to lookup() and set datatype

https://gerrit.wikimedia.org/r/644770

Change 641862 merged by Jbond:
[operations/puppet@production] mediawiki::common: hiera -> lookup, add data types

https://gerrit.wikimedia.org/r/641862

Change 644363 merged by Alexandros Kosiaris:
[operations/puppet@production] k8s: replace hiera with lookup

https://gerrit.wikimedia.org/r/644363

Change 644357 merged by Dzahn:
[operations/puppet@production] conftool: replace hiera() with lookup()

https://gerrit.wikimedia.org/r/644357

Change 644770 merged by Elukey:
[operations/puppet@production] hadoop: Migrate hiera() to lookup() and set datatype

https://gerrit.wikimedia.org/r/644770

Change 645110 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] superset: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/645110

Change 645110 merged by Elukey:
[operations/puppet@production] superset: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/645110

Change 633029 abandoned by Dzahn:
[operations/puppet@production] mediawiki: replace hiera with lookup, add data types in all profiles

Reason:
mostly duplicate and new change is easier than rebasing this now

https://gerrit.wikimedia.org/r/633029

Change 633029 restored by Dzahn:
[operations/puppet@production] mediawiki: replace hiera with lookup, add data types in all profiles

https://gerrit.wikimedia.org/r/633029

Change 645202 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] realm: replace hiera() with lookup()

https://gerrit.wikimedia.org/r/645202

Change 645203 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] query_service/updater: replace hiera() with lookup()

https://gerrit.wikimedia.org/r/645203

Change 633029 merged by Dzahn:
[operations/puppet@production] mediawiki: replace hiera with lookup, add data types in all profiles

https://gerrit.wikimedia.org/r/633029

Change 645202 merged by Dzahn:
[operations/puppet@production] realm: replace hiera() with lookup()

https://gerrit.wikimedia.org/r/645202

Change 645206 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] ntp: replace hiera() with lookup()

https://gerrit.wikimedia.org/r/645206

Change 645833 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] presto: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/645833

Change 645833 merged by Elukey:
[operations/puppet@production] presto: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/645833

Change 645203 merged by Dzahn:
[operations/puppet@production] query_service/updater: replace hiera() with lookup()

https://gerrit.wikimedia.org/r/645203

Change 645206 merged by Dzahn:
[operations/puppet@production] ntp: replace hiera() with lookup(), move use_chrony to parameters

https://gerrit.wikimedia.org/r/645206

Change 648348 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] kafkatee: Migrate hiera() to lookup() and set data type

https://gerrit.wikimedia.org/r/648348

Change 648349 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] mjolnir: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/648349

Change 648349 merged by Elukey:
[operations/puppet@production] mjolnir: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/648349

Change 648348 merged by Elukey:
[operations/puppet@production] kafkatee: Migrate hiera() to lookup() and set data type

https://gerrit.wikimedia.org/r/648348

Change 649325 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] mjolnir: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/649325

Change 649325 merged by Elukey:
[operations/puppet@production] mjolnir: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/649325

Change 649708 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] etcd: add data types, replace hiera with lookup

https://gerrit.wikimedia.org/r/649708

Change 649721 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] druid: Migrate hiera() to lookup() and set data type in monitoring

https://gerrit.wikimedia.org/r/649721

Change 649707 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] mediawiki/jobrunner: create beta role, remove hiera lookup

https://gerrit.wikimedia.org/r/649707

Change 649707 merged by Dzahn:
[operations/puppet@production] mediawiki/jobrunner: create beta role, remove hiera lookup

https://gerrit.wikimedia.org/r/649707

Change 649721 merged by Elukey:
[operations/puppet@production] druid: Migrate hiera() to lookup() and set data type in monitoring

https://gerrit.wikimedia.org/r/649721

Change 650492 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] druid: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/650492

Change 650492 merged by Elukey:
[operations/puppet@production] druid: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/650492

Change 650617 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] druid: Migrate hiera() to lookup() and setting datatype in middlemanager

https://gerrit.wikimedia.org/r/650617

Change 649708 merged by Dzahn:
[operations/puppet@production] etcd: add data types, replace hiera with lookup

https://gerrit.wikimedia.org/r/649708

Change 650617 merged by Elukey:
[operations/puppet@production] druid: Migrate hiera() to lookup() and setting datatype in middlemanager

https://gerrit.wikimedia.org/r/650617

Change 650993 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] druid: Migrate hiera() to lookup() and setting datatype in middlemanager

https://gerrit.wikimedia.org/r/650993

Change 650993 merged by Elukey:
[operations/puppet@production] druid: Migrate hiera() to lookup() and setting datatype in middlemanager

https://gerrit.wikimedia.org/r/650993

Change 651640 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cache: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/651640

Change 650631 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] puppet_compiler: hiera->lookup

https://gerrit.wikimedia.org/r/650631

Change 650637 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] mariadb::maintenance: hiera->lookup

https://gerrit.wikimedia.org/r/650637

Change 650635 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] swap: hiera->lookup

https://gerrit.wikimedia.org/r/650635

Change 650632 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] prometheus:node_exporter: hiera->lookup

https://gerrit.wikimedia.org/r/650632

Change 650634 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] pybaltest: convert to role/profile, hiera->lookup

https://gerrit.wikimedia.org/r/650634

Change 650631 merged by Dzahn:
[operations/puppet@production] puppet_compiler: hiera->lookup

https://gerrit.wikimedia.org/r/650631

Change 650632 merged by Dzahn:
[operations/puppet@production] prometheus:node_exporter: hiera->lookup

https://gerrit.wikimedia.org/r/650632

Change 650634 merged by Jbond:
[operations/puppet@production] pybaltest: convert to role/profile, hiera->lookup

https://gerrit.wikimedia.org/r/650634

Change 651834 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] etcd::v3: hiera->lookup

https://gerrit.wikimedia.org/r/651834

Change 642649 merged by Marostegui:
[operations/puppet@production] tendril: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/642649

Change 650635 merged by Dzahn:
[operations/puppet@production] swap: hiera->lookup

https://gerrit.wikimedia.org/r/650635

Change 654521 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] hive: Migrate hiera() to lookup() and setting datatype in metastore

https://gerrit.wikimedia.org/r/654521

Change 650637 merged by Dzahn:
[operations/puppet@production] mariadb::maintenance: hiera->lookup

https://gerrit.wikimedia.org/r/650637

Change 654521 merged by Klausman:
[operations/puppet@production] hive: Migrate hiera() to lookup() and setting datatype in metastore

https://gerrit.wikimedia.org/r/654521

Change 651640 merged by Klausman:
[operations/puppet@production] cache: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/651640

Change 654635 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] eventschemas: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/654635

Change 654635 merged by Elukey:
[operations/puppet@production] eventschemas: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/654635

Change 655065 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] hive: Migrate hiera() to lookup() and setting datatype in serve

https://gerrit.wikimedia.org/r/655065

Change 655073 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] hadoop: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/655073

Change 651834 merged by Dzahn:
[operations/puppet@production] etcd::v3: hiera->lookup

https://gerrit.wikimedia.org/r/651834

Change 655193 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cache: Migrate hiera() to lookup() and setting datatype in statsv

https://gerrit.wikimedia.org/r/655193

Change 655193 merged by Elukey:
[operations/puppet@production] cache: Migrate hiera() to lookup() and setting datatype in statsv

https://gerrit.wikimedia.org/r/655193

Change 655073 merged by Elukey:
[operations/puppet@production] hadoop: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/655073

Change 655065 merged by Elukey:
[operations/puppet@production] hive: Migrate hiera() to lookup() and setting datatype in serve

https://gerrit.wikimedia.org/r/655065

Change 655508 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::base: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/655508

Change 655511 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] pybal::testing: convert to role/profile, hiera->lookup

https://gerrit.wikimedia.org/r/655511

Change 655513 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] kubernetes::master: add data types, hiera->lookup

https://gerrit.wikimedia.org/r/655513

Change 655515 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] discovery:client: hiera->lookup, add data type

https://gerrit.wikimedia.org/r/655515

Change 655516 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] monitoring::host: move hostgroup_default to params, hiera->lookup

https://gerrit.wikimedia.org/r/655516

Change 655518 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] redis::slave: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/655518

Change 655790 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cache: Make statsd address an argument and hiera() -> lookup()

https://gerrit.wikimedia.org/r/655790

Change 655511 merged by Dzahn:
[operations/puppet@production] pybal::testing: convert to role/profile, hiera->lookup

https://gerrit.wikimedia.org/r/655511

Change 655515 merged by Dzahn:
[operations/puppet@production] discovery:client: hiera->lookup, add data type

https://gerrit.wikimedia.org/r/655515

Change 656015 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cache: Migrate hiera() to lookup() and setting datatype in eventlogging

https://gerrit.wikimedia.org/r/656015

Change 642470 merged by Gehel:
[operations/puppet@production] query_service: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/642470

Change 655513 merged by Dzahn:
[operations/puppet@production] kubernetes::master: add data types, hiera->lookup

https://gerrit.wikimedia.org/r/655513

Change 656266 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] query_service: Migrate hiera() to lookup() in common.pp

https://gerrit.wikimedia.org/r/656266

Change 656266 merged by Ryan Kemper:
[operations/puppet@production] query_service: Migrate hiera() to lookup() in common.pp

https://gerrit.wikimedia.org/r/656266

Change 655790 merged by Elukey:
[operations/puppet@production] cache: Make statsd address an argument and hiera() -> lookup()

https://gerrit.wikimedia.org/r/655790

Change 656015 merged by Elukey:
[operations/puppet@production] cache: Migrate hiera() to lookup() and setting datatype in eventlogging

https://gerrit.wikimedia.org/r/656015

Change 656530 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] query_service: Migrate hiera() to lookup() in gui

https://gerrit.wikimedia.org/r/656530

Change 656531 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] eventlogging: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/656531

Change 656530 merged by Gehel:
[operations/puppet@production] query_service: Migrate hiera() to lookup() in gui

https://gerrit.wikimedia.org/r/656530

Change 656531 merged by Elukey:
[operations/puppet@production] eventlogging: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/656531

Change 657040 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] bacula: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657040

Change 657043 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cloudinfra: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657043

Change 657044 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] query_service: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657044

Change 657043 merged by Marostegui:
[operations/puppet@production] cloudinfra: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657043

Change 657045 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] eventlogging: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657045

Change 657045 merged by Elukey:
[operations/puppet@production] eventlogging: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657045

Change 657047 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] kafka: Use lookup() instead of hiera() in code comment

https://gerrit.wikimedia.org/r/657047

Change 657047 merged by Elukey:
[operations/puppet@production] kafka: Use lookup() instead of hiera() in code comment

https://gerrit.wikimedia.org/r/657047

Change 657044 merged by Gehel:
[operations/puppet@production] query_service: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657044

Change 657040 merged by Jcrespo:
[operations/puppet@production] bacula: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657040

Change 657363 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] refinery: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657363

Change 657364 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] analytics: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657364

Change 657364 merged by Elukey:
[operations/puppet@production] analytics: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657364

Change 655518 merged by Dzahn:
[operations/puppet@production] redis::slave: hiera->lookup, add data types

https://gerrit.wikimedia.org/r/655518

Change 655516 merged by Dzahn:
[operations/puppet@production] monitoring::host: move hostgroup_default to params, hiera->lookup

https://gerrit.wikimedia.org/r/655516

Change 657363 merged by Elukey:
[operations/puppet@production] refinery: Migrate hiera() to lookup()

https://gerrit.wikimedia.org/r/657363

Change 657560 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] logstash: Migrate hiera() to lookup() and setting datatype

https://gerrit.wikimedia.org/r/657560

Change 657958 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes

https://gerrit.wikimedia.org/r/657958