hiera() functions have been deprecated and will be removed in Puppet 6:
https://puppet.com/docs/puppet/5.1/hiera_migrate_functions.html
https://puppet.com/docs/puppet/5.5/hiera_migrate.html#updated-classic-hiera-function-calls
Future-proof code by switching to lookup() now
https://gerrit.wikimedia.org/r/q/topic:%22hiera-lookup%22+(status:open%20OR%20status:merged)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T294906 Puppet Improvements 2021/2022 | |||
| Open | jbond | T265138 Work required to prepare for puppet 6 | |||
| Resolved | Dzahn | T209953 Use lookup() instead of hiera() in Puppet |
Change 657045 merged by Elukey:
[operations/puppet@production] eventlogging: Migrate hiera() to lookup() and setting datatype
Change 657047 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] kafka: Use lookup() instead of hiera() in code comment
Change 657047 merged by Elukey:
[operations/puppet@production] kafka: Use lookup() instead of hiera() in code comment
Change 657044 merged by Gehel:
[operations/puppet@production] query_service: Migrate hiera() to lookup()
Change 657040 merged by Jcrespo:
[operations/puppet@production] bacula: Migrate hiera() to lookup() and setting datatype
Change 657363 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] refinery: Migrate hiera() to lookup()
Change 657364 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] analytics: Migrate hiera() to lookup()
Change 657364 merged by Elukey:
[operations/puppet@production] analytics: Migrate hiera() to lookup()
Change 655518 merged by Dzahn:
[operations/puppet@production] redis::slave: hiera->lookup, add data types
Change 655516 merged by Dzahn:
[operations/puppet@production] monitoring::host: move hostgroup_default to params, hiera->lookup
Change 657363 merged by Elukey:
[operations/puppet@production] refinery: Migrate hiera() to lookup()
Change 657560 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] logstash: Migrate hiera() to lookup() and setting datatype
Change 657958 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes
Change 658079 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] cache: Migrate hiera() to lookup() and set datatypes in frontend
Change 657958 merged by Vgutierrez:
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes
Change 658079 merged by Vgutierrez:
[operations/puppet@production] cache: Migrate hiera() to lookup() and set datatypes in frontend
Change 657560 merged by Filippo Giunchedi:
[operations/puppet@production] logstash: Migrate hiera() to lookup() and setting datatype
Change 658397 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs primary
Change 658503 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] Migrate hiera() to lookup() and set datatypes in purge.pp
Change 658503 merged by Vgutierrez:
[operations/puppet@production] Migrate hiera() to lookup() and set datatypes in purge.pp
Change 658397 merged by Bstorm:
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs primary
Change 659048 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] etcd::replication: hiera -> lookup, add data types
Change 655508 merged by Dzahn:
[operations/puppet@production] profile::base: hiera->lookup, add data types
Change 659048 merged by Dzahn:
[operations/puppet@production] etcd::replication: hiera -> lookup, add data types
Change 659071 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] base::certificates: hiera->lookup, add data types
Change 659073 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] tlsproxy::prometheus: hiera->lookup, add data types
Change 659140 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] lvs: Migrate hiera() to lookup() and set datatypes in realserver
Change 659141 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] wmcs: Migrate hiera() to lookup() in nfsclient
Change 659140 merged by Giuseppe Lavagetto:
[operations/puppet@production] lvs: Migrate hiera() to lookup() in realserver
Change 659336 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs secondary
Change 659073 merged by Dzahn:
[operations/puppet@production] tlsproxy::prometheus: hiera->lookup
Change 659380 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::kubernetes::deployment_server::helmfile: hiera -> lookup
Change 659075 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] monitoring::service: hiera -> lookup, add data types
Change 659381 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::docker::storage::thinpool: hiera -> lookup
Change 659389 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::kubernetes::node: hiera -> lookup, add data types
Change 659392 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::redis::multidc: hiera -> lookup, add data types
Change 659400 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::rsyslog::udp_localhost_compat: hiera -> lookup
Change 659401 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::rsyslog::netdev_kafka_relay: hiera -> lookup
Change 659404 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] role::postgres::master: hiera -> lookup
Change 659141 merged by Bstorm:
[operations/puppet@production] wmcs: Migrate hiera() to lookup() in nfsclient
Change 659336 merged by Bstorm:
[operations/puppet@production] wmcs: Migrate hiera() to lookup() and set datatypes in nfs secondary
Change 659389 merged by Alexandros Kosiaris:
[operations/puppet@production] profile::kubernetes::node: hiera -> lookup, add data types
Change 659380 merged by Alexandros Kosiaris:
[operations/puppet@production] profile::kubernetes::deployment_server::helmfile: hiera -> lookup
Change 659381 merged by Alexandros Kosiaris:
[operations/puppet@production] profile::docker::storage::thinpool: hiera -> lookup
Change 659789 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet-lint/wmf_styleguide-check@master] Add check to error when calling to hiera()
Change 659075 merged by Dzahn:
[operations/puppet@production] monitoring::service: hiera -> lookup
Change 659071 merged by Dzahn:
[operations/puppet@production] base::certificates: hiera->lookup, add data types
Change 659401 merged by Dzahn:
[operations/puppet@production] profile::rsyslog::netdev_kafka_relay: hiera -> lookup
Change 659400 merged by Dzahn:
[operations/puppet@production] profile::rsyslog::udp_localhost_compat: hiera -> lookup
Change 659404 merged by Dzahn:
[operations/puppet@production] role::postgres::master: hiera -> lookup
Change 660951 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::docker::storage::loopback: hiera -> lookup
Change 660953 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] labs_bootstrapvz: hiera -> lookup
Change 661070 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] tlsproxy::localssl hiera->lookup
Change 660951 merged by Dzahn:
[operations/puppet@production] profile::docker::storage::loopback: hiera -> lookup
Change 659392 merged by Dzahn:
[operations/puppet@production] profile::redis::multidc: hiera -> lookup, add data types
Change 660953 merged by Dzahn:
[operations/puppet@production] labs_bootstrapvz: hiera -> lookup
Change 661070 merged by Vgutierrez:
[operations/puppet@production] tlsproxy::localssl hiera->lookup
Change 661916 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] ldap: Migrate hiera() to lookup()
Change 662008 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] grafana: replace hiera inside hiera with lookup
Change 662013 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] netmon: replace hiera within hiera with lookup
Change 662021 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] hieradata/common: replace hiera within hiera with lookup
Change 662022 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] netbox: replace hiera inside hiera with lookup
Change 662026 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] wmcs::monitoring: replace hiera inside hiera with lookup
Change 662033 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::rsyslog::udp_json_logback_compat: hiera -> lookup
Change 662033 merged by Dzahn:
[operations/puppet@production] profile::rsyslog::udp_json_logback_compat: hiera -> lookup
Change 662008 merged by Dzahn:
[operations/puppet@production] grafana: replace hiera inside hiera with lookup
Change 662013 merged by Dzahn:
[operations/puppet@production] netmon: replace hiera within hiera with lookup
Change 662022 merged by Dzahn:
[operations/puppet@production] netbox: replace hiera inside hiera with lookup
Change 662021 merged by Dzahn:
[operations/puppet@production] hieradata/common: replace hiera within hiera with lookup
Change 662026 merged by Dzahn:
[operations/puppet@production] wmcs::monitoring: replace hiera inside hiera with lookup
Change 661916 merged by Dzahn:
[operations/puppet@production] ldap: Migrate hiera() to lookup()
This would be done if it wasn't for a single remaining case:
Could you guys fix this one please?
62 puppetmaster::servers:
63 "%{hiera('puppetmaster')}":
64 - { worker: "%{hiera('puppetmaster')}", loadfactor: 10 }
65Change 663289 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] cloud: replace hiera in hiera with lookup
Change 663289 merged by Dzahn:
[operations/puppet@production] cloud: replace hiera in hiera with lookup
After many many patches this is now actually DONE!
No more hiera() in any .pp file across the entire operations/puppet.
https://docs.google.com/spreadsheets/d/1mSy8EGvbHinxBy2CqsPfhO3udYEUPyx2f4DzI1xTNx4/edit?usp=sharing
Special thanks to @Ladsgroup and @jbond
Change 659789 merged by Jbond:
[operations/puppet-lint/wmf_styleguide-check@master] Add check to error when calling to hiera()
Change 664297 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] Gemfile: increase dependency for wmf_style-stylegude-check
Change 664298 had a related patch set uploaded (by Jbond; owner: John Bond):
[integration/config@master] operations/puppet: update to pick up new wmf_style-stylegudie-check
Change 664297 merged by Jbond:
[operations/puppet@production] Gemfile: increase dependency for wmf_style-stylegude-check
Change 664298 merged by jenkins-bot:
[integration/config@master] operations/puppet: update to pick up new wmf_style-stylegudie-check
Mentioned in SAL (#wikimedia-releng) [2021-02-15T15:58:46Z] <hashar> Successfully published image docker-registry.discovery.wmnet/releng/operations-puppet:0.8.1 # T209953
Change 664305 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] jjb: bump puppet image
Change 664305 merged by jenkins-bot:
[integration/config@master] jjb: bump puppet image
Change 665459 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] docker::engine: replace hiera_hash with lookup with hash merge behaviour
Change 665461 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup
Change 665462 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] profile::wmcs::instance: replace hiera_include with lookup
Change 665461 merged by Dzahn:
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup
Change 665459 merged by Dzahn:
[operations/puppet@production] docker::engine: replace hiera_hash with lookup, add data types
Change 668507 had a related patch set uploaded (by Jbond; owner: Jbond):
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup
Change 668507 merged by Dzahn:
[operations/puppet@production] ldap::config::labs: replace hiera_hash with lookup
Change 665462 merged by Andrew Bogott:
[operations/puppet@production] profile::wmcs::instance: replace hiera_include with lookup