Deferred update causes "Retrieving hash salt for user ID failed"
Closed, ResolvedPublicbug

Description

On Czech/Korean wikis, we've seen ~65 occurrences of this message (out of 570 distinct users). There is only a single message per user ID. The error is caused due to PageViews->setUserHashingSalt() happening in the context of a deferred postsend update, so when the user GETs the WelcomeSurvey the hashing salt hasn't been initialized yet. The practical implications are that the hashed values in the first two events may not be consistent for these users.

The fix is to initialize the hashing salt immediately rather than in a deferred update.

kostajh created this task.Tue, Nov 20, 8:08 PM
Restricted Application added subscribers: Urbanecm, revi, Aklapper. · View Herald TranscriptTue, Nov 20, 8:08 PM

Change 474977 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@master] Initialize hashing salt immediately instead of in deferred update

https://gerrit.wikimedia.org/r/474977

Change 474977 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/474977

Change 474997 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/474997

Change 474997 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/474997

Change 475128 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@master] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475128

Change 475128 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475128

Change 475472 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475472

Change 475472 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475472

Mentioned in SAL (#wikimedia-operations) [2018-11-26T19:25:06Z] <ebernhardson@deploy1001> Synchronized php-1.33.0-wmf.4/extensions/WikimediaEvents/includes/: SWAT T210003 T210004 EditorJourney: Adjust DeferredUpdates usage (duration: 00m 46s)

Etonkovidova removed kostajh as the assignee of this task.Mon, Nov 26, 9:27 PM
Etonkovidova closed this task as Resolved.