Page MenuHomePhabricator
Create Task
Maniphest T210004

Some events are out of order
Closed, ResolvedPublic
Actions

Description

Looking at events associated with a user from T210003: Deferred update causes "Retrieving hash salt for user ID failed", I see:

  1. 200 GET request to view the WelcomeSurvey
  2. 302 POST request to Special:CreateAccount
  3. 302 POST request to Special:WelcomeSurvey

The correct order should be

  1. 302 POST request to Special:CreateAccount
  2. 200 GET request to view the WelcomeSurvey
  3. 302 POST request to Special:WelcomeSurvey

To fix this, we could do one of the following:

  1. modify the schema to create a custom timestamp property, set this timestamp when we begin the logging process, and @nettrom_WMF can query on this timestamp instead of the one on the eventlogging capsule
  2. Use deferred updates in PRESEND mode for all event logging
  3. Use deferred updates in PRESEND mode for POST requests only

I prefer the last option.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikimediaEventswmf/1.33.0-wmf.4+14 -9EditorJourney: Adjust DeferredUpdates usage
mediawiki/extensions/WikimediaEventsmaster+14 -9EditorJourney: Adjust DeferredUpdates usage
mediawiki/extensions/WikimediaEventsmaster+14 -9EditorJourney: Adjust DeferredUpdates usage
mediawiki/extensions/WikimediaEventswmf/1.33.0-wmf.4+14 -9EditorJourney: Adjust DeferredUpdates usage
mediawiki/extensions/WikimediaEventsmaster+2 -1Transmit POST event logging data in PRESEND mode
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Nov 20 2018, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2018, 8:18 PM
gerritbot added a subscriber: gerritbot.Nov 20 2018, 8:23 PM

Change 474981 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@master] Transmit POST event logging data in PRESEND mode

https://gerrit.wikimedia.org/r/474981

gerritbot added a project: Patch-For-Review.Nov 20 2018, 8:23 PM
kostajh claimed this task.Nov 20 2018, 8:24 PM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Nov 20 2018, 8:37 PM

Change 474977 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@master] Initialize hashing salt immediately instead of in deferred update

https://gerrit.wikimedia.org/r/474977

gerritbot added a comment.Nov 20 2018, 8:38 PM

Change 474981 abandoned by Kosta Harlan:
Transmit POST event logging data in PRESEND mode

Reason:
Merged with other 474977

https://gerrit.wikimedia.org/r/474981

gerritbot added a comment.Nov 20 2018, 9:26 PM

Change 474977 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/474977

gerritbot added a comment.Nov 20 2018, 9:28 PM

Change 474997 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/474997

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 10:00 PM
gerritbot added a comment.Nov 21 2018, 12:09 AM

Change 474997 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/474997

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.4; 2018-11-13); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 21 2018, 1:00 AM
kostajh moved this task from Code Review to In Progress on the Growth-Team (Current Sprint) board.Nov 21 2018, 4:24 PM
gerritbot added a comment.Nov 21 2018, 6:42 PM

Change 475128 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@master] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475128

kostajh moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.Nov 21 2018, 6:43 PM
kostajh added a parent task: T209009: Understanding first day: post-deployment QA.Nov 21 2018, 9:06 PM
gerritbot added a comment.Nov 21 2018, 9:11 PM

Change 475128 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475128

kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Nov 21 2018, 9:26 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 21 2018, 10:00 PM
gerritbot added a comment.Nov 23 2018, 2:48 PM

Change 475472 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475472

gerritbot added a comment.Nov 26 2018, 7:10 PM

Change 475472 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.33.0-wmf.4] EditorJourney: Adjust DeferredUpdates usage

https://gerrit.wikimedia.org/r/475472

nettrom_WMF mentioned this in T210434: Understanding first day: analysis caveats.Nov 26 2018, 7:19 PM
Stashbot mentioned this in T210003: Deferred update causes "Retrieving hash salt for user ID failed".Nov 26 2018, 7:25 PM
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-11-26T19:25:06Z] <ebernhardson@deploy1001> Synchronized php-1.33.0-wmf.4/extensions/WikimediaEvents/includes/: SWAT T210003 T210004 EditorJourney: Adjust DeferredUpdates usage (duration: 00m 46s)

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.4; 2018-11-13); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 26 2018, 8:00 PM
Etonkovidova closed this task as Resolved.Nov 26 2018, 10:09 PM
Etonkovidova added a subscriber: Etonkovidova.

Checked the fix in betalabs - the order of events is correct now:
For example,

 [log]> select event_user_id,  timestamp, wiki, event_action, event_title, event_page_title, event_request_method from EditorJourney_18504997 where event_user_id=15602 order by timestamp asc\G
*************************** 1. row ***************************
       event_user_id: 15602
           timestamp: 20181126210205
                wiki: enwiki
        event_action: view
         event_title: CreateAccount
    event_page_title: Welcome, ET135!
event_request_method: POST
*************************** 2. row ***************************
       event_user_id: 15602
           timestamp: 20181126210205
                wiki: enwiki
        event_action: view
         event_title: WelcomeSurvey
    event_page_title: Welcome, ET135!
event_request_method: GET
*************************** 3. row ***************************
       event_user_id: 15602
           timestamp: 20181126210231
                wiki: enwiki
        event_action: view
         event_title: WelcomeSurvey
    event_page_title: Welcome, ET135!
event_request_method: POST
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL