EventBus extension started emitting rev_count as a string
Closed, ResolvedPublic

Description

The rev_count field in the even schemas is defined as integer, but it started being emitted as a string. It's taken directly from the argument of the ArticleDeleteComplete hook. The argument is for some reason not documented, so it's not exactly a change in the documented public API. I believe it started from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/469354/

Restricted Application added a project: Analytics. · View Herald TranscriptTue, Nov 20, 10:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 475011 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475011

Change 475011 merged by jenkins-bot:
[mediawiki/core@master] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475011

Mentioned in SAL (#wikimedia-analytics) [2018-11-26T15:41:46Z] <ottomata> stopped producing revision-score events with old schema; merged and deployed new schema; petr to deploy change to produce events with new schema soon. https://phabricator.wikimedia.org/T210013

Mentioned in SAL (#wikimedia-analytics) [2018-11-26T15:47:30Z] <ottomata> moved old raw revision-score data to hdfs in /user/otto/revision_score_old_schema_raw - T210013

Change 475893 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@wmf/1.33.0-wmf.4] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475893

Change 475893 merged by Mobrovac:
[mediawiki/core@wmf/1.33.0-wmf.4] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475893

Mentioned in SAL (#wikimedia-operations) [2018-11-27T12:39:46Z] <mobrovac@deploy1001> Synchronized php-1.33.0-wmf.4/includes/page/WikiPage.php: Convert $archivedRevisionCount to integer - T210013 T210451 (duration: 00m 47s)