EventBus extension started emitting rev_count as a string
Closed, ResolvedPublic
Actions

Description

The rev_count field in the even schemas is defined as integer, but it started being emitted as a string. It's taken directly from the argument of the ArticleDeleteComplete hook. The argument is for some reason not documented, so it's not exactly a change in the documented public API. I believe it started from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/469354/

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	wmf/1.33.0-wmf.4	+1 -1	Convert $archivedRevisionCount to integer.
	mediawiki/core	master	+1 -1	Convert $archivedRevisionCount to integer.

Customize query in gerrit

Related Objects

Mentioned In: T210451: Kafka eqiad.mediawiki.page-delete topic is empty
Mentioned Here: T210451: Kafka eqiad.mediawiki.page-delete topic is empty

Event Timeline

• Pchelolo created this task.Nov 20 2018, 10:10 PM

Restricted Application added a project: Analytics. · View Herald TranscriptNov 20 2018, 10:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 475011 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475011

gerritbot added a project: Patch-For-Review.Nov 20 2018, 10:58 PM

The argument is for some reason not documented

Fixed in https://www.mediawiki.org/w/index.php?title=Manual:Hooks/ArticleDeleteComplete&oldid=2974967

Change 475011 merged by jenkins-bot:
[mediawiki/core@master] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475011

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 21 2018, 10:00 AM

• mobrovac closed this task as Resolved.Nov 21 2018, 4:06 PM

• mobrovac assigned this task to • Pchelolo.

• mobrovac edited projects, added Platform Team Workboards (Done with CPT), Services (done); removed Services (doing), Patch-For-Review, Platform Team Legacy (Later).

Mentioned in SAL (#wikimedia-analytics) [2018-11-26T15:41:46Z] <ottomata> stopped producing revision-score events with old schema; merged and deployed new schema; petr to deploy change to produce events with new schema soon. https://phabricator.wikimedia.org/T210013

Mentioned in SAL (#wikimedia-analytics) [2018-11-26T15:47:30Z] <ottomata> moved old raw revision-score data to hdfs in /user/otto/revision_score_old_schema_raw - T210013

Smalyshev mentioned this in T210451: Kafka eqiad.mediawiki.page-delete topic is empty.Nov 26 2018, 9:11 PM

Change 475893 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@wmf/1.33.0-wmf.4] Convert $archivedRevisionCount to integer.

https://gerrit.wikimedia.org/r/475893

gerritbot added a project: Patch-For-Review.Nov 26 2018, 10:17 PM

Change 475893 merged by Mobrovac:
[mediawiki/core@wmf/1.33.0-wmf.4] Convert $archivedRevisionCount to integer.