Page MenuHomePhabricator

ApprovedFiles.sql is not PostgreSQL-compatible
Closed, ResolvedPublic

Description

The column types in ApprovedFiles.sql (version 1.0-alpha (42a774a)) are mysql-specific, hence the CREATE TABLE statement fails with PostgreSQL. A version that seems to work with PostgreSQL would be:

CREATE TABLE /*_*/approved_revs_files (
        file_title varchar(255) NOT NULL,
        approved_timestamp char(14) NOT NULL,
        approved_sha1 varchar(32) NOT NULL
) /*$wgDBTableOptions*/;

Event Timeline

RV1971 created this task.Nov 21 2018, 11:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2018, 11:26 AM

Thanks for taking a look at the code!

You are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review them quickly and provide feedback. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!

Change 623895 had a related patch set uploaded (by Yaron Koren; owner: Yaron Koren):
[mediawiki/extensions/ApprovedRevs@master] Fix ApprovedFiles.sql to support PostgreSQL

https://gerrit.wikimedia.org/r/623895

Change 623895 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Fix ApprovedFiles.sql to support PostgreSQL

https://gerrit.wikimedia.org/r/623895

Yaron_Koren closed this task as Resolved.Sep 3 2020, 2:59 PM
Yaron_Koren claimed this task.
Yaron_Koren added a subscriber: Yaron_Koren.

I finally checked in these changes. I don't know why it took two years! @RV1971 - thanks for the patch.