Page MenuHomePhabricator
Create Task
Maniphest T210110

[EventLogging Sanitization] Fix passing of input_path_regex params to Refine
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Since we refactored parametrization of EventLoggingSanitization using Refine and ConfigHelper,
the input_path_regex parameter wasn't being properly passed to Refine. However, the default value for that parameter was a fit for EventLoggingSanitization. Some time after the refactor, the defaults were removed from Refine, uncovering the parameter issue and making the job fail.
Unfortunately, the alarms we had set for that job were not triggering, because the error was happening before the Refine call.
This task should fix the parameter passing issue.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Correctly pass input_path_regex to Refine from EventLoggingSanitizationanalytics/refinery/sourcemaster+12 -4
Customize query in gerrit

Related Objects

Event Timeline

mforns created this task.Nov 21 2018, 9:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2018, 9:27 PM
mforns added a comment.Nov 21 2018, 9:29 PM
This comment was removed by mforns.
gerritbot subscribed.Nov 21 2018, 9:30 PM

Change 475220 had a related patch set uploaded (by Mforns; owner: Mforns):
[analytics/refinery/source@master] Correctly pass input_path_regex to Refine from EventLoggingSanitization

https://gerrit.wikimedia.org/r/475220

gerritbot added a project: Patch-For-Review.Nov 21 2018, 9:30 PM
mforns renamed this task from [EventLogging Sanitization] Fix Refine parameters and cdh jars to unbreak production to [EventLogging Sanitization] Fix passing of input_path_regex params to Refine.Nov 21 2018, 9:36 PM
mforns set the point value for this task to 5.
mforns moved this task from Next Up to In Code Review on the Analytics-Kanban board.
gerritbot added a comment.Nov 21 2018, 10:58 PM

Change 475220 merged by jenkins-bot:
[analytics/refinery/source@master] Correctly pass input_path_regex to Refine from EventLoggingSanitization

https://gerrit.wikimedia.org/r/475220

mforns moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Nov 23 2018, 12:35 PM
Milimetric triaged this task as High priority.Nov 29 2018, 5:56 PM
Milimetric moved this task from Incoming to Operational Excellence on the Analytics board.
JAllemandou moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Nov 30 2018, 12:45 PM
• Nuria closed this task as Resolved.Dec 10 2018, 5:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits