Page MenuHomePhabricator

Indentation of first fieldset in Vector is mixed up due to cascade inheritance
Closed, ResolvedPublic

Description

The indentation of “Select options below to be global“ headline (noJS)/label (JS) got mixed up due to inheritance of default fieldset styling. OOUI is using fieldset for accessibility reasons.

image.png (522×782 px, 52 KB)

Expected result

The label should start horizontally on one line with other elements and in JS mode apply a margin aligned to our standard 4px divider values

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Niharika I've been actually preparing a patch as promised, just not yet submitted…

Change 475834 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/GlobalPreferences@master] Fix indentation of global selection checkbox

https://gerrit.wikimedia.org/r/475834

Assigning it to you then. :)

Change 475834 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Fix indentation of global selection checkbox

https://gerrit.wikimedia.org/r/475834