OOUI Documentation: ClippableElement: Fix typo in #$element
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	• Prtksxna
	Nov 22 2018, 10:31 AM

Description

Skills

JavaScript / JSDoc

◾️◾️◽️◽️◽️

$element is not a link and should not have the preceding #

Details

	Subject	Repo	Branch	Lines +/-
	Fix typo "#$element" in the OOUI Documentation	oojs/ui	master	+7 -7
	Fix typo "#$element" in the OOUI Documentation	mediawiki/core	master	+7 -7

Customize query in gerrit

Event Timeline

• Prtksxna created this task.Nov 22 2018, 10:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2018, 10:31 AM

• Prtksxna added projects: OOUI, Google-Code-in-2018.Nov 22 2018, 10:31 AM

https://codein.withgoogle.com/tasks/5424142758182912/

Kizule claimed this task.Dec 8 2018, 3:02 AM

Restricted Application added a project: User-Kizule. · View Herald TranscriptDec 8 2018, 3:02 AM

Change 478386 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/core@master] Fix typo "#$element" in the OOUI Documentation

https://gerrit.wikimedia.org/r/478386

gerritbot added a project: Patch-For-Review.Dec 8 2018, 3:17 AM

Kizule moved this task from Inbox to To deploy on the User-Kizule board.Dec 8 2018, 3:17 AM

Change 478386 abandoned by Zoranzoki21:
Fix typo "#$element" in the OOUI Documentation

Reason:
Will be done in oojs/ui (if I find this typo there)

https://gerrit.wikimedia.org/r/478386

Change 479269 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[oojs/ui@master] Fix typo "#$element" in the OOUI Documentation

https://gerrit.wikimedia.org/r/479269

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Dec 12 2018, 11:22 PM

Why is $element not a link? I note on https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.mixin.ClippableElement that $clippable and $clippableContainer are links. Shouldn't we be fixing $element to be a link, rather than unlinking it?

@Prtksxna JSDoc is continuing to support those links?

In T210133#4824296, @Esanders wrote:

Why is $element not a link? I note on https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.mixin.ClippableElement that $clippable and $clippableContainer are links. Shouldn't we be fixing $element to be a link, rather than unlinking it?

I thought so as well, but wasn't sure (still not) where it should link to… https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.Element-cfg-S-element?

I am not sure what I should do, so I removed assignee to me.

Change 479269 abandoned by Zoranzoki21:
Fix typo "#$element" in the OOUI Documentation