Pointers and pointer lines display slight to far right
Closed, ResolvedPublic
Actions

Description

The pointers and pointer lines are a few pixels displaced on current master with many revisions

This seems to be introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RevisionSlider/+/469651/ by reducing the arrow width by 2px. - Some calculations in code took this width into account and were not adjusted.

Details

Related Gerrit Patches:

mediawiki/extensions/RevisionSlider : master

Fixed Pointers and Pointer lines alignment

Related Objects

Mentioned In: rERSLae42b859752c: Fixed Pointers and Pointer lines alignment

Event Timeline

WMDE-Fisch created this task.Nov 23 2018, 10:38 AM

WMDE-Fisch moved this task from Incoming to Revision Slider on the TCB-Team board.

Change 475595 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/RevisionSlider@master] Fixed Pointers and Pointer lines alignment

https://gerrit.wikimedia.org/r/475595

gerritbot added a project: Patch-For-Review.Nov 24 2018, 4:46 PM

Gopavasanth mentioned this in rERSLae42b859752c: Fixed Pointers and Pointer lines alignment.Nov 24 2018, 4:52 PM

Change 475595 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fixed Pointers and Pointer lines alignment

https://gerrit.wikimedia.org/r/475595

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 7 2018, 12:01 PM

Gopavasanth closed this task as Resolved.Feb 9 2019, 3:14 PM

Gopavasanth claimed this task.

Gopavasanth removed a project: Patch-For-Review.