Page MenuHomePhabricator

Add which sitelink is moved by the Move Sitelinks gadget
Closed, ResolvedPublic

Description

Hello,

I often use the Move Sitelinks gadget and would like to see which sitelink is moved in the 2 popups of this gadget.
E.g.

move.png (592×1 px, 101 KB)

Here I have already moved 6 sitelinks and I am moving another one. The problem is I can't tell which sitelink.
As you can see, the green arrow can sometimes be far away from the link name, and I am always uncomfortable that I may have clicked on the arrow of the wrong line. Having the sitelink in the popup would eliminate the risk.

Regards

Event Timeline

Tacsipacsi added a subscriber: Tacsipacsi.

@matej_suchanek The popup created in lines 599–662 of MediaWiki:Gadget-Move.js still doesn’t contain the sitelink about to be moved.

matej_suchanek added a project: patch-welcome.
matej_suchanek added a subscriber: matej_suchanek.

Needs some refactoring (and a volunteer).

I propose this fix :

Add in each language a new label :
22a23

'legend': 'Moving $1',

This new label can be initialized with the content of label 'move'
Here is the french translation :

'legend': 'Déplacement de $1',

Then in openDialog() function, we can set the legend :
571a572,577

var message = mw.message(
        sites.length > 1 ? 'move' : 'legend',
        sites.length > 1 ? '' : sites[0]
);
$( '#sitelink-form legend' ).empty().text( message );

And please change this french label to print the sitelink $2 :

'success': 'Le lien interlangue $2 a été déplacé avec succès vers l\'élément $1.',


Here is the diff file of my proposed changes

Melderick claimed this task.

Change applied