Page MenuHomePhabricator

JSDoc WMF theme: Fix JS and CSS linting issues
Closed, ResolvedPublic

Description

Setup instructions

See https://phabricator.wikimedia.org/project/profile/3689/

Skills

JavaScript◾️◾️◾️◽️◽️
CSS◾️◾️◾️◽️◽️
CLI/npm/grunt◾️◾️◾️◾️◾️

Run grunt test and fix the linting issues. Most are solvable with a simple flag, some will need to be looked at manually.

  • Make stylelint pass
  • Make eslint pass

Event Timeline

Change 490677 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[jsdoc/wmf-theme@master] build: Update 'stylelint' to latest and make CSS files pass for first time

https://gerrit.wikimedia.org/r/490677

Change 490677 merged by jenkins-bot:
[jsdoc/wmf-theme@master] build: Update 'stylelint' to latest and make CSS files pass for first time

https://gerrit.wikimedia.org/r/490677

Change 490800 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[jsdoc/wmf-theme@master] build: Update 'eslint-config-wikimedia' and make pass

https://gerrit.wikimedia.org/r/490800

Volker_E updated the task description. (Show Details)

Change 490800 merged by jenkins-bot:
[jsdoc/wmf-theme@master] build: Update 'eslint-config-wikimedia' and make pass

https://gerrit.wikimedia.org/r/490800

Volker_E closed this task as Resolved.Feb 20 2019, 10:23 PM
Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)