Page MenuHomePhabricator
Create Task
Maniphest T210369

Add @since 1.33 tags to every new public method in BlockRestriction
Closed, ResolvedPublic1 Story Points
Actions

Description

Please add @since tags to all the new public functions and classes added.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/453081#message-96c5ff49ec268138a26ca5b4c72bddda23a64ca4

Related Objects
Search...

Event Timeline

dbarratt created this task.Nov 26 2018, 5:42 AM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 26 2018, 5:42 AM
Legoktm added a comment.Nov 26 2018, 9:00 AM

FWIW not just the BlockRestriction class, every new function needs it. I noticed this when I was looking for when Block::isSitewide() was introduced actually.

dbarratt renamed this task from Add @since tags to every new public method in BlockRestriction to Add @since 1.33 tags to every new public method in BlockRestriction.Nov 26 2018, 3:21 PM
dbarratt moved this task from Backlog to User blocking on the MediaWiki-User-management board.
TBolliger moved this task from Untriaged to Backlog on the Anti-Harassment board.Nov 26 2018, 7:56 PM
TBolliger triaged this task as Normal priority.Jan 2 2019, 8:07 PM
TBolliger set the point value for this task to 1.
TBolliger edited projects, added Anti-Harassment (Alef — א); removed Anti-Harassment.
gerritbot added a subscriber: gerritbot.Jan 8 2019, 12:52 PM

Change 482803 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Add @since tags to new public methods related to partial blocks

https://gerrit.wikimedia.org/r/482803

Tchanders claimed this task.Jan 8 2019, 1:05 PM
Tchanders moved this task from Ready to Review on the Anti-Harassment (Alef — א) board.
gerritbot added a comment.Jan 8 2019, 6:37 PM

Change 482803 merged by jenkins-bot:
[mediawiki/core@master] Add @since tags to new public methods related to partial blocks

https://gerrit.wikimedia.org/r/482803

dbarratt closed this task as Resolved.Jan 9 2019, 3:34 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL