PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	xSavitar
	Nov 26 2018, 11:58 AM

Description

Code coverage for the content-providers/McsContentProvider.php is 0% and unit tests should be written to cover all it's code.

Acceptance Criteria

Cover all methods in the file class
Code Coverage has gone up to 100%
@phuedx: See T210390#4830681.

Details

Subject	Repo	Branch	Lines +/-
Streamline McsContentProvider constructor and tests	mediawiki/extensions/MobileFrontend	master	+40 -103
Follow-up on Ie224b89787b631bd597273c20cae4	mediawiki/extensions/MobileFrontend	master	+45 -0
Revert and fix "Revert "Add PHPUnit tests for methods in McsContentProvider::class""	mediawiki/extensions/MobileFrontend	master	+186 -5
Define the default mobile content provider	operations/mediawiki-config	master	+4 -0
Add PHPUnit tests for methods in McsContentProvider::class	mediawiki/extensions/MobileFrontend	master	+206 -6
Reset default mobilefrontend provider	mediawiki/extensions/MobileFrontend	wmf/1.33.0-wmf.8	+1 -1
Reset default mobilefrontend provider	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
		Resolved		None	T210390 PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests

Event Timeline

xSavitar created this task.Nov 26 2018, 11:58 AM

xSavitar edited projects, added User-xSavitar, Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.Nov 26 2018, 12:16 PM

Change 475730 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add PHPUnit tests for methods in McsContentProvider::class

https://gerrit.wikimedia.org/r/475730

gerritbot added a project: Patch-For-Review.Nov 26 2018, 12:37 PM

xSavitar claimed this task.Nov 26 2018, 12:37 PM

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

xSavitar triaged this task as Medium priority.Nov 26 2018, 1:57 PM

This will definitely go in for Needs more work but let it undergo Round 1 (R1) review to get some feedback on how to proceed. Thanks :)

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.Nov 26 2018, 2:40 PM

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 26 2018, 9:53 PM

xSavitar moved this task from Reviewed/Resolved to Doing [WIP] on the User-xSavitar board.Nov 26 2018, 10:13 PM

Again, a request for a gentle review :), may likely move back to "Needs more work" but would like to know if this is the right direction :)

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.Nov 27 2018, 3:56 PM

xSavitar moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 7:43 PM

xSavitar moved this task from Reviewed/Resolved to Doing [WIP] on the User-xSavitar board.

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 8:56 PM

xSavitar moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 28 2018, 3:24 PM

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 4 2018, 2:13 PM

pmiazga moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 4 2018, 4:20 PM

xSavitar moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 4 2018, 10:37 PM

pmiazga closed this task as Resolved.Dec 5 2018, 9:29 PM

pmiazga removed a project: Patch-For-Review.

pmiazga updated the task description. (Show Details)

Change 475730 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add PHPUnit tests for methods in McsContentProvider::class

https://gerrit.wikimedia.org/r/475730

xSavitar awarded a token.Dec 5 2018, 9:35 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 5 2018, 10:01 PM

Change 479246 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Reset default mobilefrontend provider

https://gerrit.wikimedia.org/r/479246

gerritbot added a project: Patch-For-Review.Dec 12 2018, 4:54 PM

Change 479250 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[operations/mediawiki-config@master] Define the default mobile content provider

https://gerrit.wikimedia.org/r/479250

Change 479246 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Reset default mobilefrontend provider

https://gerrit.wikimedia.org/r/479246

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 12 2018, 7:00 PM

Change 479265 had a related patch set uploaded (by Jdlrobson; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.8] Reset default mobilefrontend provider

https://gerrit.wikimedia.org/r/479265

Change 479265 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.8] Reset default mobilefrontend provider

https://gerrit.wikimedia.org/r/479265

Mentioned in SAL (#wikimedia-operations) [2018-12-13T00:22:36Z] <dcausse@deploy1001> Synchronized php-1.33.0-wmf.8/extensions/MobileFrontend/extension.json: T210390: Reset default mobilefrontend provider (duration: 00m 53s)

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 13 2018, 1:00 AM

Looks like the units are failing in core (T211903) so I'm going to do the easiest thing and revert these tests. Please don't be too dispirited - we'll attempt these again!

Jdlrobson edited projects, added Web-Team-Backlog; removed Patch-For-Review, Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).Dec 13 2018, 5:47 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Dec 13 2018, 7:44 PM

Looks like the units are failing in core (T211903) so I'm going to do the easiest thing and revert these tests. Please don't be too dispirited - we'll attempt these again!

Sure, no problem :)

xSavitar updated the task description. (Show Details)Dec 13 2018, 8:18 PM

xSavitar moved this task from Reviewed/Resolved to Backlog on the User-xSavitar board.

Looking forward to round 2 of review!

The game continues :)

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Dec 14 2018, 6:29 PM

Per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/479757, @pmiazga submitted a PS for review, though it needs a rebase, so adjusting this appropriately.

xSavitar edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.Dec 17 2018, 11:35 AM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 9:26 PM

Change 479250 abandoned by Pmiazga:
Define the default mobile content provider

Reason:
per Jdlrobson comment

https://gerrit.wikimedia.org/r/479250

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 10:06 PM

Change 479757 had a related patch set uploaded (by Jdlrobson; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Revert and fix "Revert "Add PHPUnit tests for methods in McsContentProvider::class""

https://gerrit.wikimedia.org/r/479757

gerritbot added a project: Patch-For-Review.Dec 17 2018, 10:07 PM

Change 479757 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Revert and fix "Revert "Add PHPUnit tests for methods in McsContentProvider::class""

https://gerrit.wikimedia.org/r/479757

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 17 2018, 11:01 PM

Code Coverage has gone up to 100%

From https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/6645/console, run against PS5 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/479757/:

+------------------------------------------+-------+--------+
| Filename                                 | Old % | New %  |
+------------------------------------------+-------+--------+
| content-providers/McsContentProvider.php | 0     |  97.30 |
+------------------------------------------+-------+--------+

While code coverage is an important metric, 100% should be an aim and not a strong requirement. 97.3% is 👌

Being bold.

Change 482778 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] Follow-up on Ie224b89787b631bd597273c20cae4

https://gerrit.wikimedia.org/r/482778

While code coverage is an important metric, 100% should be an aim and not a strong requirement. 97.3% is 👌

@phuedx: So if it wasn't for @Jdlrobson, we would have let this be but yes, thanks a lot Jon for the extra push. Generally, I love 100% coverage though it's not a guarantee but I think it's always better than < 100%. In that case, 🎉🎉🎉🎉🎉🎉, with the follow up patch, the one left additional code path has been covered, now we have 100% coverage for this class. 🎉🎉🎉🎉🎉🎉🎉

xSavitar reopened this task as Open.Jan 8 2019, 10:56 AM

xSavitar moved this task from Ready for Signoff to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

xSavitar edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).

xSavitar claimed this task.Jan 8 2019, 11:41 AM

xSavitar updated the task description. (Show Details)

xSavitar moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 8 2019, 11:44 AM

Change 482797 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/MobileFrontend@master] Streamline McsContentProvider constructor and tests

https://gerrit.wikimedia.org/r/482797

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 8 2019, 12:28 PM

xSavitar moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 8 2019, 12:36 PM

pmiazga moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 8 2019, 12:56 PM

Change 482778 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Follow-up on Ie224b89787b631bd597273c20cae4

https://gerrit.wikimedia.org/r/482778

Change 482797 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Streamline McsContentProvider constructor and tests

https://gerrit.wikimedia.org/r/482797

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Jan 8 2019, 2:00 PM

• nray claimed this task.Jan 8 2019, 6:02 PM

100% code coverage now. Good job all!

• nray closed this task as Resolved.Jan 8 2019, 8:54 PM

• nray removed • nray as the assignee of this task.

• nray updated the task description. (Show Details)

• nray subscribed.

	F27824647: code-coverage.png
	Jan 8 2019, 8:43 PM

PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit testsClosed, ResolvedPublicActions