Page MenuHomePhabricator

PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests
Closed, ResolvedPublic

Description

Code coverage for the content-providers/ContentProviderFactory.php is 0% and unit tests should be written to cover all it's code.

Acceptance Criteria

  • Cover all methods in the file class
  • Code Coverage has gone up to 100%

Event Timeline

D3r1ck01 created this task.Nov 26 2018, 1:56 PM
D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.
D3r1ck01 claimed this task.
D3r1ck01 triaged this task as Normal priority.

Change 475754 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add PHPUnit tests for testing methods in ContentProviderFactory::class

https://gerrit.wikimedia.org/r/475754

@pmiazga, @Jdlrobson, I think this looks good for R1 review ;)

D3r1ck01 updated the task description. (Show Details)Nov 26 2018, 10:19 PM

A gentle plead for another review considering the comments :} Thanks!

Change 475754 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add PHPUnit tests for methods in ContentProviderFactory::class

https://gerrit.wikimedia.org/r/475754

phuedx added a subscriber: phuedx.Dec 18 2018, 10:43 AM

Code Coverage has gone up to 100%

From https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/6590/console, run against PS12 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/475754/:

+----------------------------------------------+-------+--------+
| Filename                                     | Old % | New %  |
+----------------------------------------------+-------+--------+
| content-providers/ContentProviderFactory.php | 0     | 100.00 |
+----------------------------------------------+-------+--------+
phuedx updated the task description. (Show Details)Dec 18 2018, 10:43 AM
phuedx closed this task as Resolved.
phuedx claimed this task.

Being bold.

Ohhh, thank you :)