PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests
Closed, ResolvedPublic
Actions

Description

Code coverage for the content-providers/ContentProviderFactory.php is 0% and unit tests should be written to cover all it's code.

Acceptance Criteria

Cover all methods in the file class
Code Coverage has gone up to 100%

Details

	Subject	Repo	Branch	Lines +/-
	Add PHPUnit tests for methods in ContentProviderFactory::class	mediawiki/extensions/MobileFrontend	master	+167 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
		Resolved		phuedx	T210400 PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests

Event Timeline

xSavitar claimed this task.Nov 26 2018, 1:56 PM

xSavitar triaged this task as Medium priority.

xSavitar created this task.

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

Change 475754 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Add PHPUnit tests for testing methods in ContentProviderFactory::class

https://gerrit.wikimedia.org/r/475754

gerritbot added a project: Patch-For-Review.Nov 26 2018, 2:34 PM

@pmiazga, @Jdlrobson, I think this looks good for R1 review ;)

xSavitar moved this task from To Do to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 26 2018, 5:20 PM

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 26 2018, 9:50 PM

A gentle plead for another review considering the comments :} Thanks!

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 1:53 AM

xSavitar moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 12:23 PM

xSavitar moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 7:43 PM

xSavitar moved this task from Reviewed/Resolved to Doing [WIP] on the User-xSavitar board.

xSavitar moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 28 2018, 4:09 PM

xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 29 2018, 5:34 PM

xSavitar updated the task description. (Show Details)Nov 29 2018, 5:46 PM

xSavitar moved this task from Doing to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 4 2018, 2:14 PM

xSavitar moved this task from Reviewed/Resolved to Doing [WIP] on the User-xSavitar board.Dec 4 2018, 4:50 PM

Should be good for review now!

pmiazga moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 13 2018, 11:08 PM

xSavitar moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 15 2018, 1:55 PM

Jdlrobson removed xSavitar as the assignee of this task.Dec 17 2018, 10:13 PM

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Change 475754 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add PHPUnit tests for methods in ContentProviderFactory::class

https://gerrit.wikimedia.org/r/475754

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 17 2018, 11:01 PM

Code Coverage has gone up to 100%

From https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/6590/console, run against PS12 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/475754/:

+----------------------------------------------+-------+--------+
| Filename                                     | Old % | New %  |
+----------------------------------------------+-------+--------+
| content-providers/ContentProviderFactory.php | 0     | 100.00 |
+----------------------------------------------+-------+--------+

Being bold.

Ohhh, thank you :)

xSavitar removed a project: User-xSavitar.Dec 18 2018, 10:48 AM

Thank you, @D3r1ck01!

PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit testsClosed, ResolvedPublicActions