Page MenuHomePhabricator

Replace `json-stable-stringify` with `fast-json-stable-stringify`
Closed, ResolvedPublic

Description

There's a fast-json-stable-stringify package that claims to be faster then the json-stable-stringify we're using and does not have additional dependencies. We need to evaluate it and possibly start using it instead of json-stable-stringify.

Event Timeline

mobrovac renamed this task from Replace `son-stable-stringify` with `fast-json-stable-stringify` to Replace `json-stable-stringify` with `fast-json-stable-stringify`.Nov 26 2018, 6:44 PM
mobrovac triaged this task as Medium priority.
mobrovac removed a subscriber: Aklapper.

The fast-json-stable-stringify library is indeed 20% faster than the one we're using and it does not have any dependencies. Even though we do not use this lib in critical for performance code paths, I think replacing is still a good idea.

mobrovac closed this task as Resolved.EditedMar 18 2019, 9:47 PM
mobrovac subscribed.

As far as I can tell all of the repositories have been addressed. Thank you, @Clarakosi !