Page MenuHomePhabricator

[Regression] Settings list items not left aligned
Closed, ResolvedPublic

Description

Regression

List items on the Settings screen and the Notification settings screen are appearing pushed to the right, but should instead be left aligned.


Settings screen

DesignCurrent implementation

Notification settings screen

DesignCurrent implementation

Event Timeline

Change 476456 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Fix: Remove extra indentation in Settings without overriding properties

https://gerrit.wikimedia.org/r/476456

Change 476456 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Remove extra indentation in Settings without overriding properties

https://gerrit.wikimedia.org/r/476456

Testing app build 2.7.268-alpha-2018-12-04 on the devices Samsung Galaxy Express 3 SM-J120A (Android 6.0.1) and Samsung Galaxy S9 SM-G960U1 (Android 8). According to the screencaps I've uploaded below everything is left aligned (whether airplane mode is on or off) so this is fixed.

Disclaimer: I can only review this based on the screens @Nicholas.tsg’s posted above. My Android studio instance is still crashing (just scheduled a meeting with Dmitry about it). It doesn’t seem to be available on android-builds.wmflabs.org yet as well.

Based on these screens above, this is good to go from a design perspective!